[PATCH] Xfstests: make 014 only run on xfs

[PATCH] Xfstests: make 014 only run on xfs

[Josef Bacik]

This test relies on mounting with -o allocsize, which is an xfs specific mount
option, so make the test only work on xfs.  Thanks,

Signed-off-by: Josef Bacik <josef@redhat.com>
---
 014 |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/014 b/014
index e6e0a6f..c6be9bd 100755
--- a/014
+++ b/014
@@ -44,7 +44,7 @@ _cleanup()
 . ./common.rc
 . ./common.filter
 
-_supported_fs generic
+_supported_fs xfs
 _supported_os IRIX Linux
 
 _require_sparse_files
-- 
1.6.6.1

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] Xfstests: make 014 only run on xfs

[Christoph Hellwig]

On Wed, Jan 26, 2011 at 09:05:29AM -0500, Josef Bacik wrote:
> This test relies on mounting with -o allocsize, which is an xfs specific mount
> option, so make the test only work on xfs.  Thanks,

Except for the recently added option it's fine for other filesystems.
Just conditionalize setting the option.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] Xfstests: make 014 only run on xfs

[Dave Chinner]

On Wed, Jan 26, 2011 at 09:05:29AM -0500, Josef Bacik wrote:
> This test relies on mounting with -o allocsize, which is an xfs specific mount
> option, so make the test only work on xfs.  Thanks,

Oh, sorry, my fault. Perhaps something like this instead?

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com


xfstests: conditionalise allocsize option in 014

allocsize is an XFS specific mount option, and hence causes the test
to fail on other filesystems. Only set the mount option on xfs
filesystems.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
 014 |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/014 b/014
index e6e0a6f..057e4d9 100755
--- a/014
+++ b/014
@@ -53,8 +53,10 @@ _setup_testdir
 # ensure EOF preallocation doesn't massively extend the runtime of this test
 # by limiting the amount of preallocation and therefore the amount of blocks
 # zeroed during the truncfile test run.
-umount $TEST_DIR
-_test_mount -o allocsize=64k
+if [ "$FSTYP" == "xfs" ]; then
+	umount $TEST_DIR
+	_test_mount -o allocsize=64k
+fi
 
 echo "brevity is wit..."
 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] Xfstests: make 014 only run on xfs

[Alex Elder]

On Thu, 2011-01-27 at 11:59 +1100, Dave Chinner wrote:
> On Wed, Jan 26, 2011 at 09:05:29AM -0500, Josef Bacik wrote:
> > This test relies on mounting with -o allocsize, which is an xfs specific mount
> > option, so make the test only work on xfs.  Thanks,
> 
> Oh, sorry, my fault. Perhaps something like this instead?

Since test 014 reportedly works on other filesystem
types provided the allocsize option isn't provided,
Dave's version looks better.

Josef will you please take a look over--and preferably
test--what Dave proposed, and if you agree offer your
signoff?

Thanks.

					-Alex

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] Xfstests: make 014 only run on xfs

[Josef Bacik]

On Tue, Feb 01, 2011 at 05:48:57PM -0600, Alex Elder wrote:
> On Thu, 2011-01-27 at 11:59 +1100, Dave Chinner wrote:
> > On Wed, Jan 26, 2011 at 09:05:29AM -0500, Josef Bacik wrote:
> > > This test relies on mounting with -o allocsize, which is an xfs specific mount
> > > option, so make the test only work on xfs.  Thanks,
> > 
> > Oh, sorry, my fault. Perhaps something like this instead?
> 
> Since test 014 reportedly works on other filesystem
> types provided the allocsize option isn't provided,
> Dave's version looks better.
> 
> Josef will you please take a look over--and preferably
> test--what Dave proposed, and if you agree offer your
> signoff?
>

Yup looks reasonable and runs fine on btrfs.  You can add

Signed-off-by: Josef Bacik <josef@redhat.com>

Thanks,

Josef 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs