From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p0V4F5Ix067013 for ; Sun, 30 Jan 2011 22:15:06 -0600 Received: from ipmail04.adl6.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 5290229D56D for ; Sun, 30 Jan 2011 20:17:32 -0800 (PST) Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net [150.101.137.141]) by cuda.sgi.com with ESMTP id nW7K1qpBuz5aWcRy for ; Sun, 30 Jan 2011 20:17:32 -0800 (PST) Date: Mon, 31 Jan 2011 15:17:29 +1100 From: Dave Chinner Subject: Re: [patch] xfsprogs: repair pagefault due to missed out sanity NULL check Message-ID: <20110131041729.GJ21311@dastard> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Ajeet Yadav Cc: xfs@oss.sgi.com T24gRnJpLCBKYW4gMjgsIDIwMTEgYXQgMDg6MTM6MDRQTSArMDkwMCwgQWplZXQgWWFkYXYgd3Jv dGU6Cj4gbGlieGZzX3B1dGJ1ZigpIGlzIGNhbGxlZCB3aXRoIGJwID0gTlVMTCwgcmVzdWx0aW5n IGluIHBhZ2VmYXVsdCBpbgo+IGxpYnB0aHJlYWQuCj4gCj4gRnVuY3Rpb24gZGFfcmVhZF9idWYo KSBhbGxvY2F0ZSBhcnJheSBvZiB4ZnNfYnVmX3QgKgo+IAo+ICAgICogeGZzX2J1Zl90ICAgICAg ICoqYnBsaXN0OyoKPiAKPiAqICAgIGJwbGlzdCA9IGNhbGxvYyhuZXgsIHNpemVvZigqYnBsaXN0 KSk7Kgo+IAo+IFJlYWQgYW5kIGZpbGwgaXQgdXNpbmcKPiAKPiAqZm9yIChpID0gMDsgaSA8IG5l eDsgaSsrKSB7Cj4gICAgIGJwbGlzdFtpXSA9IGxpYnhmc19yZWFkYnVmKCkqCj4gCj4gKiAgICBp ZiAoIWJwbGlzdFtpXSl7Cj4gICAgICAgICBnb3RvIGZhaWxlZDsKPiAgICAgfSAgKgo+IAo+ICp9 Kgo+IAo+ICpmYWlsZWQ6Cj4gICAgICAgICBmb3IgKGkgPSAwOyBpIDwgbmV4OyBpKyspCj4gICAg ICAgICAgICAgICAgIGxpYnhmc19wdXRidWYoYnBsaXN0W2ldKTsqCj4gCj4gTm93IGFzc3VtZSBu ZXggPSAxMCwKPiAKPiAxLiBXaWxsIGNyZWF0ZSBicGxpc3QgZm9yIDEwIGFycmF5IGVsZW1lbnRz Lgo+IAo+IDMuIFJlYWRpbmcgZnJvbSBkaXNrIDAsMSwgMiwgMwo+IAo+IDQuIFdoZW4gcmVhZGlu ZyBmcm9tIGRpc2sgNCwgVVNCIGlzIHJlbW92ZWQKPiAKPiA1LiBsaWJ4ZnNfcmVhZGJ1ZigpIHdp bGwgYXQgZmFpbCwgcGJsaXN0WzRdID0gTlVMTCwgZ290byBmYWlsZWQuCj4gCj4gNi4gU2luY2Ug b25seSA0IGJ1ZmZlcnMgd2VyZSByZWFkIHN1Y2Nlc3NmdWxseSwgc28gb25seSA0IGFyZSBpbiBs b2NrIHN0YXRlLgo+IAo+IDcuICBFcnJvciBoYW5kbGluZyB3aWxsIHVubG9jayBidWZmZXIgZnJv bSAxLTEwCj4gCj4gOC4gQnVmZmVyIDAtMyB3ZXJlIHJlYWQgc3VjY2Vzc2Z1bGx5LCBoZW5jZSB3 aWxsIGhhdmUgdmFsaWQgcGRsaXN0W2ldCj4gCj4gOS4gQWNjZXNzIHBibGlzdFs0XSA9PSBOVUxM LCB0aGVyZWZvcmUgdW5sb2NraW5nIHdpbGwgc2V0IGJwID09IE5VTEwgaW4KPiBsaWJ4ZnNfcHV0 YnVmKGJwKTsKPiAxMC4gUGFnZSBmYXVsdCBpbiBsaWJwdGhyZWFkCj4gCj4gCj4gU29sdXRpb24g cGF0Y2ggYXR0YWNoZWQgd2l0aCBtYWlsCgpDYW4geW91IHBsZWFzZSBpbmNsdWRlIHRoZSBwYXRj aGVzIGluLWxpbmUgaW4geW91ciBlbWFpbCByYXRoZXIgdGhhbgphcyBiYXNlNjQgZW5jb2RlZCBh dHRhY2htZW50cz8gRXZlbiB0aG91Z2ggaXQgaXMgZm9yIHhmc3Byb2dzLCB3ZQphc2sgdGhhdCB0 aGUgc2FtZSBwcm9jZXNzIGlzIGZvbGxvd2VkIGFzIHBlciBrZXJuZWwgcGF0Y2hlcy4gVGhhdApp bmNsdWRlcyBhZGTRlm5nIFNpZ25lZC1vZmYtYnkgdGFncyB0byB0aGUgcGF0Y2hlcy4uLgoKU2Vl IERvY3VtZW50YXRpb24vU3VibWl0dGluZ1BhdGNoZXM6Cgp8IDcpIE5vIE1JTUUsIG5vIGxpbmtz LCBubyBjb21wcmVzc2lvbiwgbm8gYXR0YWNobWVudHMuICBKdXN0IHBsYWluIHRleHQuCnwgCnwg TGludXMgYW5kIG90aGVyIGtlcm5lbCBkZXZlbG9wZXJzIG5lZWQgdG8gYmUgYWJsZSB0byByZWFk IGFuZCBjb21tZW50Cnwgb24gdGhlIGNoYW5nZXMgeW91IGFyZSBzdWJtaXR0aW5nLiAgSXQgaXMg aW1wb3J0YW50IGZvciBhIGtlcm5lbAp8IGRldmVsb3BlciB0byBiZSBhYmxlIHRvICJxdW90ZSIg eW91ciBjaGFuZ2VzLCB1c2luZyBzdGFuZGFyZCBlLW1haWwKfCB0b29scywgc28gdGhhdCB0aGV5 IG1heSBjb21tZW50IG9uIHNwZWNpZmljIHBvcnRpb25zIG9mIHlvdXIgY29kZS4KfCAKfCBGb3Ig dGhpcyByZWFzb24sIGFsbCBwYXRjaGVzIHNob3VsZCBiZSBzdWJtaXR0aW5nIGUtbWFpbCAiaW5s aW5lIi4KfCBXQVJOSU5HOiAgQmUgd2FyeSBvZiB5b3VyIGVkaXRvcidzIHdvcmQtd3JhcCBjb3Jy dXB0aW5nIHlvdXIgcGF0Y2gsCnwgaWYgeW91IGNob29zZSB0byBjdXQtbi1wYXN0ZSB5b3VyIHBh dGNoLgp8IAp8IERvIG5vdCBhdHRhY2ggdGhlIHBhdGNoIGFzIGEgTUlNRSBhdHRhY2htZW50LCBj b21wcmVzc2VkIG9yIG5vdC4KfCBNYW55IHBvcHVsYXIgZS1tYWlsIGFwcGxpY2F0aW9ucyB3aWxs IG5vdCBhbHdheXMgdHJhbnNtaXQgYSBNSU1FCnwgYXR0YWNobWVudCBhcyBwbGFpbiB0ZXh0LCBt YWtpbmcgaXQgaW1wb3NzaWJsZSB0byBjb21tZW50IG9uIHlvdXIKfCBjb2RlLiAgQSBNSU1FIGF0 dGFjaG1lbnQgYWxzbyB0YWtlcyBMaW51cyBhIGJpdCBtb3JlIHRpbWUgdG8gcHJvY2VzcywKfCBk ZWNyZWFzaW5nIHRoZSBsaWtlbGlob29kIG9mIHlvdXIgTUlNRS1hdHRhY2hlZCBjaGFuZ2UgYmVp bmcgYWNjZXB0ZWQuCnwgCnwgRXhjZXB0aW9uOiAgSWYgeW91ciBtYWlsZXIgaXMgbWFuZ2xpbmcg cGF0Y2hlcyB0aGVuIHNvbWVvbmUgbWF5IGFzawp8IHlvdSB0byByZS1zZW5kIHRoZW0gdXNpbmcg TUlNRS4KfCAKfCBTZWUgRG9jdW1lbnRhdGlvbi9lbWFpbC1jbGllbnRzLnR4dCBmb3IgaGludHMg YWJvdXQgY29uZmlndXJpbmcKfCB5b3VyIGUtbWFpbCBjbGllbnQgc28gdGhhdCBpdCBzZW5kcyB5 b3VyIHBhdGNoZXMgdW50b3VjaGVkLgoKQW5kIGFzIGl0IHN1Z2dlc3RzLCByZWFkIERvY3VtZW50 YXRpb24vZW1haWwtY2xpZW50cy50eHQgb24gaG93IHRvCmRvIHRoaXMgd2l0aCB2YXJpb3VzIG1h aWwgY2xpZW50cy4KCkNoZWVycywKCkRhdmUuCi0tIApEYXZlIENoaW5uZXIKZGF2aWRAZnJvbW9y Yml0LmNvbQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K eGZzIG1haWxpbmcgbGlzdAp4ZnNAb3NzLnNnaS5jb20KaHR0cDovL29zcy5zZ2kuY29tL21haWxt YW4vbGlzdGluZm8veGZzCg==