From: Dave Chinner <david@fromorbit.com>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/3] libxlog: sync up with 2.6.38 kernel code
Date: Mon, 14 Feb 2011 16:46:22 +1100 [thread overview]
Message-ID: <20110214054622.GK2559@dastard> (raw)
In-Reply-To: <20110214051005.GI2559@dastard>
On Mon, Feb 14, 2011 at 04:10:05PM +1100, Dave Chinner wrote:
> On Wed, Feb 09, 2011 at 03:49:03PM -0600, Alex Elder wrote:
> > On Mon, 2011-01-10 at 19:44 +1100, Dave Chinner wrote:
> > > From: Dave Chinner <dchinner@redhat.com>
> > >
> > > Update libxlog with the current 2.6.38 kernel code and well as
> > > updating the necessary parts of libxfs and variaous header files to
> > > ensure that it compiles correctly.
....
> > > diff --git a/libxfs/xfs_mount.c b/libxfs/xfs_mount.c
> > > index 02bff42..dde9678 100644
> > > --- a/libxfs/xfs_mount.c
> > > +++ b/libxfs/xfs_mount.c
> > > @@ -270,7 +270,6 @@ xfs_mount_common(xfs_mount_t *mp, xfs_sb_t *sbp)
> > > mp->m_blockmask = sbp->sb_blocksize - 1;
> > > mp->m_blockwsize = sbp->sb_blocksize >> XFS_WORDLOG;
> > > mp->m_blockwmask = mp->m_blockwsize - 1;
> > > - INIT_LIST_HEAD(&mp->m_del_inodes);
> >
> > This hunk belongs in the next patch, not this one.
> >
>
> OK.
Actually, it has to be in this patch, because the only reason it
compiled prior to this patch was that INIT_LIST_HEAD() was defined
to a null macro. It is actually implemented in this patch, so this
does need to be removed here or the patch won't compile....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-02-14 5:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 8:44 [PATCH 0/3] xfsprogs: sync up with 2.6.38 kernel code V2 Dave Chinner
2011-01-10 8:44 ` [PATCH 1/3] libxfs: reintroduce old xfs_repair radix-tree code Dave Chinner
2011-01-24 8:58 ` Christoph Hellwig
2011-02-09 18:05 ` Alex Elder
2011-02-14 0:36 ` Dave Chinner
2011-01-10 8:44 ` [PATCH 2/3] libxlog: sync up with 2.6.38 kernel code Dave Chinner
2011-01-24 8:47 ` Christoph Hellwig
2011-01-24 23:47 ` Dave Chinner
2011-02-09 21:49 ` Alex Elder
2011-02-14 5:10 ` Dave Chinner
2011-02-14 5:31 ` Dave Chinner
2011-02-14 5:46 ` Dave Chinner [this message]
2011-01-10 8:44 ` [PATCH 3/3] libxfs: sync files " Dave Chinner
2011-01-24 8:57 ` Christoph Hellwig
2011-01-24 23:55 ` Dave Chinner
2011-02-10 19:02 ` Alex Elder
2011-02-14 6:30 ` [PATCH 0/3] xfsprogs: sync up with 2.6.38 kernel code V2 Dave Chinner
2011-02-22 20:45 ` Alex Elder
2011-03-07 18:14 ` Alex Elder
2011-03-07 18:24 ` Christoph Hellwig
2011-04-13 16:34 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110214054622.GK2559@dastard \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox