From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH V3] xfs_quota: don't try to report quotas which aren't there.
Date: Mon, 21 Feb 2011 08:16:31 +1100 [thread overview]
Message-ID: <20110220211631.GB3166@dastard> (raw)
In-Reply-To: <4D5EB423.9040009@redhat.com>
On Fri, Feb 18, 2011 at 12:02:11PM -0600, Eric Sandeen wrote:
> Red Hat bug #669333 - xfs_quota generates "XFS_GETQUOTA: No such process" errors
> shows that if you do this for a filesystem w/o group quota enabled:
>
> # xfs_quota -x -c ' report -h ' /xfsquota"
>
> You'll get this output:
>
> User quota on /xfsquota (/dev/vdb)
> Blocks
> User ID Used Soft Hard Warn/Grace
> ---------- ---------------------------------
> root 0 0 0 00 [------]
>
> XFS_GETQUOTA: No such process
> XFS_GETQUOTA: No such process
> ...
>
> because we're calling XFS_GETQUOTA for types which aren't enabled.
>
> The below patch fixes it for me, just ignoring types that aren't
> there.
>
> V2: Thanks to Arkadiusz Miskiewicz for pointing out the simpler fix.
> V3: Thanks again to Arkadiusz for suggesting fixing dump as well
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks sane.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-02-20 21:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 17:47 [PATCH] xfs_quota: don't try to report quotas which aren't there Eric Sandeen
2011-02-18 17:55 ` [PATCH V2] " Eric Sandeen
2011-02-18 18:02 ` [PATCH V3] " Eric Sandeen
2011-02-20 21:16 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110220211631.GB3166@dastard \
--to=david@fromorbit.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox