* [PATCH] xfs_repair: inode flags check should use flags
@ 2011-02-23 22:29 Dave Chinner
2011-02-23 22:31 ` Alex Elder
0 siblings, 1 reply; 3+ messages in thread
From: Dave Chinner @ 2011-02-23 22:29 UTC (permalink / raw)
To: xfs; +Cc: aelder
From: Dave Chinner <dchinner@redhat.com>
The RT bitmap inode format flag check should use the flag, not the
bit definition. As a result, it is incorrectly detecting inodes with
the prealloc flag set as has having an invalid bit set.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
---
repair/dinode.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/repair/dinode.c b/repair/dinode.c
index fad15b2..3a092e4 100644
--- a/repair/dinode.c
+++ b/repair/dinode.c
@@ -2551,11 +2551,11 @@ process_dinode_int(xfs_mount_t *mp,
XFS_DIFLAG_RTINHERIT);
}
}
- if (flags & XFS_DIFLAG_NEWRTBM_BIT) {
+ if (flags & XFS_DIFLAG_NEWRTBM) {
/* must be a rt bitmap inode */
if (lino != mp->m_sb.sb_rbmino) {
do_warn(_("inode %llu not rt bitmap"), lino);
- flags &= ~XFS_DIFLAG_NEWRTBM_BIT;
+ flags &= ~XFS_DIFLAG_NEWRTBM;
}
}
if (flags & (XFS_DIFLAG_RTINHERIT |
--
1.7.2.3
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs_repair: inode flags check should use flags
2011-02-23 22:29 [PATCH] xfs_repair: inode flags check should use flags Dave Chinner
@ 2011-02-23 22:31 ` Alex Elder
2011-02-23 23:45 ` Dave Chinner
0 siblings, 1 reply; 3+ messages in thread
From: Alex Elder @ 2011-02-23 22:31 UTC (permalink / raw)
To: Dave Chinner; +Cc: xfs
On Thu, 2011-02-24 at 09:29 +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> The RT bitmap inode format flag check should use the flag, not the
> bit definition. As a result, it is incorrectly detecting inodes with
> the prealloc flag set as has having an invalid bit set.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Looks good.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs_repair: inode flags check should use flags
2011-02-23 22:31 ` Alex Elder
@ 2011-02-23 23:45 ` Dave Chinner
0 siblings, 0 replies; 3+ messages in thread
From: Dave Chinner @ 2011-02-23 23:45 UTC (permalink / raw)
To: Alex Elder; +Cc: xfs
On Wed, Feb 23, 2011 at 04:31:46PM -0600, Alex Elder wrote:
> On Thu, 2011-02-24 at 09:29 +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > The RT bitmap inode format flag check should use the flag, not the
> > bit definition. As a result, it is incorrectly detecting inodes with
> > the prealloc flag set as has having an invalid bit set.
> >
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
>
> Looks good.
>
> Reviewed-by: Alex Elder <aelder@sgi.com>
pushed.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-23 23:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-23 22:29 [PATCH] xfs_repair: inode flags check should use flags Dave Chinner
2011-02-23 22:31 ` Alex Elder
2011-02-23 23:45 ` Dave Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox