From: Dave Chinner <david@fromorbit.com>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v3, 10/16] xfsprogs: metadump: encapsulate the nametable code
Date: Thu, 24 Feb 2011 13:00:25 +1100 [thread overview]
Message-ID: <20110224020025.GX3166@dastard> (raw)
In-Reply-To: <201102182121.p1ILL2oE029134@stout.americas.sgi.com>
On Fri, Feb 18, 2011 at 03:21:01PM -0600, Alex Elder wrote:
> The name table used to find duplicates in metadump.c is allocated
> dynamically, but there's no real need to do so. Just make it a BSS
> global array and drop the initialization call.
>
> Meanwhile, encapsulate the code that adds entries to and looks up
> entries in the table into their own functions. Use the lookup
> function to detect a duplicate name in a case not previously
> checked.
>
> Change the naming scheme to use "nametable" as a prefix rather than
> a suffix.
>
> Finally, now that it's easy to do so, issue a warning if we find
> that we're falling back to not obfuscating the name, but that name
> has already been used in the current directory. (This can happen if
> a obfuscated earlier happens to match a subsequently found "real"
> name.)
>
> Signed-off-by: Alex Elder <aelder@sgi.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-02-24 1:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 21:21 [PATCH v3, 10/16] xfsprogs: metadump: encapsulate the nametable code Alex Elder
2011-02-24 2:00 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110224020025.GX3166@dastard \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox