From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p1O22Cn7098901 for ; Wed, 23 Feb 2011 20:02:13 -0600 Received: from ipmail07.adl2.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 1D71EA04CB9 for ; Wed, 23 Feb 2011 18:04:56 -0800 (PST) Received: from ipmail07.adl2.internode.on.net (ipmail07.adl2.internode.on.net [150.101.137.131]) by cuda.sgi.com with ESMTP id RG8GOOCUL3FDfsAG for ; Wed, 23 Feb 2011 18:04:56 -0800 (PST) Date: Thu, 24 Feb 2011 13:04:55 +1100 From: Dave Chinner Subject: Re: [PATCH v3, 12/16] xfsprogs: metadump: no need for local copy of name when obfuscating Message-ID: <20110224020455.GZ3166@dastard> References: <201102182121.p1ILL23t029159@stout.americas.sgi.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <201102182121.p1ILL23t029159@stout.americas.sgi.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Alex Elder Cc: xfs@oss.sgi.com On Fri, Feb 18, 2011 at 03:21:02PM -0600, Alex Elder wrote: > The local "newname" buffer in obfuscate_name() is used to hold > an obfuscated name as it gets generated. But it is always copied > back into the passed-in name buffer, so we might as well just use > the name buffer passed directly and avoid the copy. > > Signed-off-by: Alex Elder Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs