From: Dave Chinner <david@fromorbit.com>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v3, 14/16] xfsprogs: metadump: fix duplicate handling once and for all
Date: Thu, 3 Mar 2011 15:57:14 +1100 [thread overview]
Message-ID: <20110303045714.GE15097@dastard> (raw)
In-Reply-To: <1298657632.1990.6988.camel@doink>
On Fri, Feb 25, 2011 at 12:13:52PM -0600, Alex Elder wrote:
> On Thu, 2011-02-24 at 19:39 +1100, Dave Chinner wrote:
> > On Fri, Feb 18, 2011 at 03:21:02PM -0600, Alex Elder wrote:
> > > This is a case where I think I've solved a problem to death.
> >
> > :)
>
> After getting through the patch, you see what I mean?
>
> I have some long discussion below. It is mostly
> explanation for why I ended up with this, so it may
> not convince you it's worth keeping (but I hope so).
It certainly helps understand how you came to this solution, and it
definitely helps explain the _why_ of the code. Hence I think that
if you include the main points from this discussion in in the code,
then it will be OK. Stuff like documenting the change in the number
of alternatives as the length increases, why the bitflip table was
sized and when (if ever) we'd need to consider expanding it, that
handling duplicates of less than 5 characters is not important as we
don't obfuscate names of that length so the low number of alternates
is not an issue, etc.
I know that will make the comments longer than the code, but it
really does need to explain why it has been done this way. That will
save time when someone has to understand it in the future, and I'm
fine with that.....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-03-03 4:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 21:21 [PATCH v3, 14/16] xfsprogs: metadump: fix duplicate handling once and for all Alex Elder
2011-02-24 8:39 ` Dave Chinner
2011-02-25 18:13 ` Alex Elder
2011-03-03 4:57 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110303045714.GE15097@dastard \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox