From: Dave Chinner <david@fromorbit.com>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v4, 13/16] xfsprogs: metadump: move duplicate name handling into its own function
Date: Thu, 3 Mar 2011 15:59:58 +1100 [thread overview]
Message-ID: <20110303045958.GF15097@dastard> (raw)
In-Reply-To: <1298657628.1990.6987.camel@doink>
On Fri, Feb 25, 2011 at 12:13:48PM -0600, Alex Elder wrote:
> Move the handling of duplicate names into its own function. As a
> result, all names other than "lost+found" files (not just those that
> get obfuscated) will be checked to avoid duplication.
>
> This makes the local buffer newname[] in generate_obfuscated_name()
> unnecessary, so just drop it and use the passed-in name.
>
> Signed-off-by: Alex Elder <aelder@sgi.com>
>
> Updates:
> - A comment about handling of a leading '/' character is now modified
> to match the updated code, rather than being deleted altogether.
> - Renamed handle_duplicates() to be handle_duplicate_name().
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-03-03 4:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 21:21 [PATCH v3, 13/16] xfsprogs: metadump: move duplicate name handling into its own function Alex Elder
2011-02-24 2:12 ` Dave Chinner
2011-02-25 18:13 ` [PATCH v4, " Alex Elder
2011-03-03 4:59 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110303045958.GF15097@dastard \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox