From: Dave Chinner <david@fromorbit.com>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v4, 09/16] xfsprogs: metadump: don't loop on too many dups
Date: Thu, 3 Mar 2011 16:07:31 +1100 [thread overview]
Message-ID: <20110303050731.GH15097@dastard> (raw)
In-Reply-To: <1298657624.1990.6986.camel@doink>
On Fri, Feb 25, 2011 at 12:13:44PM -0600, Alex Elder wrote:
> Don't just loop indefinitely when an obfuscated name comes up as a
> duplicate. Count the number of times we've found a duplicate and if
> if it gets excessive despite choosing names at random, just give up
> and use the original name without obfuscation.
>
> Technically, a typical 5-character name has 255 other names that can
> have the same hash value. But the algorithm doesn't hit all
> possible names (far from it) so duplicates are still possible.
>
> Signed-off-by: Alex Elder <aelder@sgi.com>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
>
> Updates (v4):
> - Rearranged things a bit so that if too many duplicates are
> encountered, a warning gets emitted.
>
> Dave already signed off on it but the update was different enough I
> thought I should post it once more.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-03-03 5:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 21:21 [PATCH v3, 09/16] xfsprogs: metadump: don't loop on too many dups Alex Elder
2011-02-24 1:55 ` Dave Chinner
2011-02-25 18:13 ` [PATCH v4, " Alex Elder
2011-03-03 5:07 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110303050731.GH15097@dastard \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox