public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Marc Lehmann <schmorp@schmorp.de>
To: xfs@oss.sgi.com
Subject: Re: corruption, xfs_repair 3.1.4 segfaults
Date: Fri, 4 Mar 2011 11:29:39 +0100	[thread overview]
Message-ID: <20110304102939.GA10416@schmorp.de> (raw)
In-Reply-To: <20110304085146.368046e7@galadriel2.home>

On Fri, Mar 04, 2011 at 08:51:46AM +0100, Emmanuel Florac <eflorac@intellique.com> wrote:
> Ah, I think the problem may lie in the loop device. Try to run

At least the xfs_repair problem cannot be in the loop device:

>From the strace it's obvious that xfs_repair tries to read close to 2**64
bytes, and then crashes when the kernel rightly says that it can't do that.

It also shows that xfs_repair tries to allocate 3gb of memory (which is in
addition to the 1gb it already uses at that point), which is far more then
it should (specifying -m 990 didn't change that), which is another bug in
xfs_repair.

I think that, no matter what the loop device would do, xfs_repair is buggy
- it simply shouldn't crash, no matter how corrupted the filesystem is.

As a sidenote, I am now about 30% in recovering (copying) and
verifying the data, and it seems the volume isn't corrupted completely
(fortunately), so I can probably recover the important stuff, and reformat
the partition, so this might not turn out to be data loss (fortunately :).

> xfs_repair -f /file/path 
> 
> (not using the loop device).

that will not work, as xfs_repair has no encryption support (which is why
the loop device is used in the first place).

-- 
                The choice of a       Deliantra, the free code+content MORPG
      -----==-     _GNU_              http://www.deliantra.net
      ----==-- _       generation
      ---==---(_)__  __ ____  __      Marc Lehmann
      --==---/ / _ \/ // /\ \/ /      schmorp@schmorp.de
      -=====/_/_//_/\_,_/ /_/\_\

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2011-03-04 10:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-02 17:58 corruption, xfs_repair 3.1.4 segfaults Marc Lehmann
2011-03-02 21:43 ` Emmanuel Florac
2011-03-04  7:11   ` Marc Lehmann
2011-03-04  7:51     ` Emmanuel Florac
2011-03-04 10:29       ` Marc Lehmann [this message]
2011-03-04 11:14         ` Emmanuel Florac
2011-03-04 16:31           ` Marc Lehmann
2011-03-04 19:18             ` Eric Sandeen
2011-03-04 17:30           ` corruption, xfs_repair 3.1.4 segfaults, xfs_repair 2.9.8 works Marc Lehmann
2011-03-04 18:17             ` Emmanuel Florac
2011-03-04 15:07 ` corruption, xfs_repair 3.1.4 segfaults Eric Sandeen
  -- strict thread matches above, loose matches on Subject: below --
2011-03-02 17:57 Marc Lehmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110304102939.GA10416@schmorp.de \
    --to=schmorp@schmorp.de \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox