From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 3/3] xfs: do not immediately reuse busy extent ranges
Date: Wed, 9 Mar 2011 06:11:07 -0500 [thread overview]
Message-ID: <20110309111107.GB17556@infradead.org> (raw)
In-Reply-To: <1299538896.2578.897.camel@doink>
On Mon, Mar 07, 2011 at 05:01:36PM -0600, Alex Elder wrote:
> This time I just scanned most of the change, since it appears
> it's almost the same except for the (renamed) xfs_alloc_busy_trim()
> function.
Yes.
> It looks correct now, but I have a few things for you
> to consider. I'll wait for your response in case you want to
> change anything. After that I'll pull in the three patches
> (probably tomorrow).
For now please just pull the first two. There's a fair chance number
three will change based on how the discard work goes.
> I agree that the notation (from Dave) that you use here
> is very helpful in visualizing what's going on. But
> the underlying code is pretty simple, and it gets somewhat
> lost in the comments I think. I therefore would kind of
> prefer to have the explanation moved up above the function.
> It clearly labels the cases being treated, and references
> to those can be put in the code, below.
>
> (This is a style thing, so if you feel strongly that it's
> better as you have it, so be it.)
I tried that before, but matching the cases to numbers in comments
wasn't very readable so I switch to this notation.
> All the nice diagrams refer to the variable "fbno"
> and "fend" using "bno" and "end. I think you should
> either drop the "f" in the variables or add it to
> the comments.
Indeed. I did a last minute cleanup to consolidate the duplicate
variables and didn't update the comments.
> (Something like that anyway, I just wanted to provide
> an example rather than just saying "it's wrong.")
Ok.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-03-09 11:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 12:59 [PATCH 0/3] avoid busy extents during user data allocations Christoph Hellwig
2011-03-04 12:59 ` [PATCH 1/3] xfs: clean up the xfs_alloc_compute_aligned calling convention Christoph Hellwig
2011-03-04 12:59 ` [PATCH 3/3] xfs: do not immediately reuse busy extent ranges Christoph Hellwig
2011-03-07 23:01 ` Alex Elder
2011-03-09 11:11 ` Christoph Hellwig [this message]
2011-03-04 13:19 ` [PATCH 0/3] avoid busy extents during user data allocations Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110309111107.GB17556@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox