From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: fix a few build warnings
Date: Thu, 10 Mar 2011 12:24:18 -0500 [thread overview]
Message-ID: <20110310172418.GA13390@infradead.org> (raw)
In-Reply-To: <201103041937.p24JbVtP004804@stout.americas.sgi.com>
> lio_random_methods(long curr_mask)
> {
> int mask=0;
> - long random_bit();
> + long random_bit(long);
This should use the prototype from include/random_range.h instead.
Otherwise looks good to me,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-03-10 17:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 19:37 [PATCH] xfstests: fix a few build warnings Alex Elder
2011-03-09 17:34 ` Eric Sandeen
2011-03-10 17:24 ` Christoph Hellwig [this message]
2011-03-10 22:16 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110310172418.GA13390@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox