From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfstests: some refinements on "make depend"
Date: Thu, 10 Mar 2011 12:26:45 -0500 [thread overview]
Message-ID: <20110310172644.GC13390@infradead.org> (raw)
In-Reply-To: <201103041937.p24Jbfh5004820@stout.americas.sgi.com>
On Fri, Mar 04, 2011 at 01:37:41PM -0600, Alex Elder wrote:
> Make it so "make depend" is a generic target, like "make clean".
>
> Each Makefile has a "depend" target that indicates whether making
> dependencies means creating ".dep" or creating ".ltdep" (or, I
> suppose, both, though none do that right now). Both files get
> created even if there are no CFILES to scan (to ensure the target
> up-to-date). The "default" target now depends on "depend" (there is
> no "ltdepend" any more).
>
> Remove the "depend" and "ltdepend" definitions from the "buildrules"
> file; only the actual generated files (".dep" and ".ltdep") remain
> as generic targets. The "depend' target is still defined as phony.
>
> Do a shell trick when expanding the value of CFILES, to avoid a
> problem that occurs if it is created by "make" by concatentating two
> empty strings. The problem was that in that case CFILES will
> contain a space, and that wasn't getting treated as empty as
> desired.
>
> Make the rule for tool/lib dependencies more generic, to reflect the
> general desire that "lib" subdirectories need to be built before
> things in the "tool" subdirectories.
Can we instead port over the generic dependency generation from
xfsprogs/xfsdump?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-03-10 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 19:37 [PATCH 2/2] xfstests: some refinements on "make depend" Alex Elder
2011-03-10 17:26 ` Christoph Hellwig [this message]
2011-03-10 22:09 ` Alex Elder
2011-03-11 10:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110310172644.GC13390@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox