From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: rework "dmapi" subtree build mechanism
Date: Thu, 10 Mar 2011 12:29:43 -0500 [thread overview]
Message-ID: <20110310172943.GD13390@infradead.org> (raw)
In-Reply-To: <201103041937.p24Jbk5W004828@stout.americas.sgi.com>
> LIB_SUBDIRS = include lib
> TOOL_SUBDIRS = ltp src m4
> +ifeq ($(HAVE_DMAPI), true)
> +TOOL_SUBDIRS += dmapi
> +endif
Does this work with the way we generate source tarballs on make dist?
In xfsprogs we have special variables for source files that don't get
build.
> @@ -0,0 +1,30 @@
> +#
> +# Copyright (c) 2011 SGI All Rights Reserved.
> +#
I think a license would be more useful than all rights reserved here.
Except for that the patch looks sane to me, and having a consistent
build system is a good thing.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-03-10 17:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 19:37 [PATCH] xfstests: rework "dmapi" subtree build mechanism Alex Elder
2011-03-10 17:29 ` Christoph Hellwig [this message]
2011-03-10 22:16 ` Alex Elder
2011-03-11 10:11 ` Christoph Hellwig
2011-03-10 22:33 ` Alex Elder
-- strict thread matches above, loose matches on Subject: below --
2011-03-04 20:00 Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110310172943.GD13390@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox