[PATCH] xfstests: fix parallel make

[PATCH] xfstests: fix parallel make

[Alex Elder]

Having both "include/builddefs" and "include/config.h" as
dependencies for the default target results in a parallel
invocation of "make" spawning two concurrent attempts to
do the configure step--and that doesn't work.

Creating one of those two will result in the other getting
created, so there's no need to list both as dependencies.

There are several other mysterious dependencies that serve
no purpose, so get rid of them.

Signed-off-by: Alex Elder <aelder@sgi.com>

---
 Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/Makefile
===================================================================
--- a/Makefile
+++ b/Makefile
@@ -38,7 +38,7 @@ endif
 
 SUBDIRS = $(LIB_SUBDIRS) $(TOOL_SUBDIRS)
 
-default: include/builddefs include/config.h new remake check $(TESTS)
+default: include/builddefs $(TESTS)
 ifeq ($(HAVE_BUILDDEFS), no)
 	$(Q)$(MAKE) $(MAKEOPTS) $@
 else

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: fix parallel make

[Christoph Hellwig]

On Fri, Mar 04, 2011 at 04:35:07PM -0600, Alex Elder wrote:
> Having both "include/builddefs" and "include/config.h" as
> dependencies for the default target results in a parallel
> invocation of "make" spawning two concurrent attempts to
> do the configure step--and that doesn't work.
> 
> Creating one of those two will result in the other getting
> created, so there's no need to list both as dependencies.
> 
> There are several other mysterious dependencies that serve
> no purpose, so get rid of them.


Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs