From: Dave Chinner <david@fromorbit.com>
To: Alex Elder <aelder@sgi.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
XFS Mailing List <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: don't name variables "panic"
Date: Sun, 13 Mar 2011 11:49:00 +1100 [thread overview]
Message-ID: <20110313004859.GF15097@dastard> (raw)
In-Reply-To: <1299847191.3462.1.camel@doink>
On Fri, Mar 11, 2011 at 06:39:51AM -0600, Alex Elder wrote:
> The new xfs_alert_tag() used a variable named "panic",
> and that is to be avoided. Rename it.
>
> Signed-off-by: Alex Elder <aelder@sgi.com>
My fault. Fix looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Cheers,
Dave
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-03-13 2:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 12:21 [next] xfs: error: called object 'panic' is not a function Geert Uytterhoeven
2011-03-11 12:39 ` [PATCH] xfs: don't name variables "panic" Alex Elder
2011-03-13 0:49 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110313004859.GF15097@dastard \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=geert@linux-m68k.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox