From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 4/6] xfs: introduce background inode reclaim work
Date: Fri, 18 Mar 2011 15:00:06 +1100 [thread overview]
Message-ID: <20110318040006.GF30195@dastard> (raw)
In-Reply-To: <20110310174054.GD19609@infradead.org>
On Thu, Mar 10, 2011 at 12:40:54PM -0500, Christoph Hellwig wrote:
> Why do we still keep the inode reclaim in the syncer work? If we
> already have this one doing it I don't think we need it there as well.
Ok. Removed.
> > /*
> > + * Queue a new inode reclaim pass if there isn't one already in progress.
> > + * Wait for completion of the flush if necessary.
>
> No, it doesn't wait ever.
Removed.
> > + */
> > +static void
> > +xfs_syncd_queue_reclaim(
> > + struct xfs_mount *mp)
> > +{
> > + queue_delayed_work(xfs_syncd_wq, &mp->m_reclaim_work,
> > + xfs_syncd_centisecs / 5 * msecs_to_jiffies(10));
>
> What explanation is there for the magic 5? E.g. why do we neeed to run
> it exactly 5 times as often as the normal sync work?
It doesn't have to be exactly 5x more frequent, just that it needs
to run quite a bit more often than the normal sync work. tens times
more often seems like overkill and a lot of overhead given the scan
reclaim does, while two times more often isn't sufficient to avoid
significant build up of dirty reclaimable inodes that need to be
written before they can be reclaimed..
> Should it have it's
> own tunable?
Perhaps. I'm not convinced it is necessary, though.
> And isn't ever 6 seconds by default a little often on
> systems trying to saver power, especiall if there aren't any inodes to
> reclaim? Should we trigger starting this work off having reclaimable
> inodes tagged in the radix tree?
Yes, probably should. I'll see if I can do that easily.
> > + /* first unpin all the dirty and stale inodes. */
> > + xfs_log_force(mp, XFS_LOG_SYNC);
>
> So we force out the log every 6 seconds. That's a lot more often than
> most other filesystem and might have adverse performance impact.
I'll remove that and leave it for the sync inode reclaim to force
out the log...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-03-18 3:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 0:05 [PATCH 0/6] xfs: Reduce OOM kill problems under heavy load V2 Dave Chinner
2011-03-10 0:05 ` [PATCH 1/6] xfs: introduce inode cluster buffer trylocks for xfs_iflush Dave Chinner
2011-03-10 17:31 ` Christoph Hellwig
2011-03-10 0:05 ` [PATCH 2/6] xfs: introduce a xfssyncd workqueue Dave Chinner
2011-03-10 17:34 ` Christoph Hellwig
2011-03-18 3:39 ` Dave Chinner
2011-03-10 0:05 ` [PATCH 3/6] xfs: convert ENOSPC inode flushing to use new syncd workqueue Dave Chinner
2011-03-10 17:35 ` Christoph Hellwig
2011-03-18 3:39 ` Dave Chinner
2011-03-10 0:05 ` [PATCH 4/6] xfs: introduce background inode reclaim work Dave Chinner
2011-03-10 17:40 ` Christoph Hellwig
2011-03-18 4:00 ` Dave Chinner [this message]
2011-03-10 0:05 ` [PATCH 5/6] xfs: convert the xfsaild threads to a workqueue Dave Chinner
2011-03-10 17:48 ` Christoph Hellwig
2011-03-18 4:06 ` Dave Chinner
2011-03-19 13:45 ` Christoph Hellwig
2011-04-03 0:38 ` Dave Chinner
2011-04-03 10:59 ` Christoph Hellwig
2011-04-04 2:11 ` Dave Chinner
2011-03-10 0:05 ` [PATCH 6/6] xfs: push the AIL from memory reclaim and periodic sync Dave Chinner
2011-03-10 21:31 ` Christoph Hellwig
2011-03-18 4:07 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110318040006.GF30195@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox