From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 5/6] xfs: convert the xfsaild threads to a workqueue
Date: Fri, 18 Mar 2011 15:06:48 +1100 [thread overview]
Message-ID: <20110318040648.GG30195@dastard> (raw)
In-Reply-To: <20110310174818.GE19609@infradead.org>
On Thu, Mar 10, 2011 at 12:48:18PM -0500, Christoph Hellwig wrote:
> > STATIC int __init
> > +xfs_init_workqueues(void)
>
> > +STATIC void __exit
> > +xfs_destroy_workqueues(void)
>
> I don't think these helpers are overly useful.
I'm thinking of adding a few more workqueues, so I though I'd split
them out like zone initialisation at the outset....
>
> > + xfs_ail_wq = alloc_workqueue("xfsail", WQ_CPU_INTENSIVE, 8);
>
> > +}
>
>
> > +static void
> > +xfs_ail_push_queue(
> > + struct xfs_ail *ailp,
> > + xfs_lsn_t threshold_lsn,
> > + int tout)
> > +{
> > + if (XFS_LSN_CMP(threshold_lsn, ailp->xa_target) > 0) {
> > + ailp->xa_target = threshold_lsn;
> > + queue_delayed_work(xfs_syncd_wq, &ailp->xa_work, tout);
>
> tout is always one in the only caller and thus doesn't need to be
> passed. But I think you really want a timeout of 0 here to queue it up
> ASAP (it translates to a direct queue_work() call internally).
>
> Also this function could simply be merged into it's only and relatively
> simple caller.
It gets used by a second caller in the next patch that uses a
timeout of zero. The idea of adding a delay to a normal push is to
rate limit the number of times we do work so we always work on
batches rather a few items at a time in multiple executions of the
work.
I'll see if it's simpler to just do this work directly in teh
callers, though.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-03-18 4:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 0:05 [PATCH 0/6] xfs: Reduce OOM kill problems under heavy load V2 Dave Chinner
2011-03-10 0:05 ` [PATCH 1/6] xfs: introduce inode cluster buffer trylocks for xfs_iflush Dave Chinner
2011-03-10 17:31 ` Christoph Hellwig
2011-03-10 0:05 ` [PATCH 2/6] xfs: introduce a xfssyncd workqueue Dave Chinner
2011-03-10 17:34 ` Christoph Hellwig
2011-03-18 3:39 ` Dave Chinner
2011-03-10 0:05 ` [PATCH 3/6] xfs: convert ENOSPC inode flushing to use new syncd workqueue Dave Chinner
2011-03-10 17:35 ` Christoph Hellwig
2011-03-18 3:39 ` Dave Chinner
2011-03-10 0:05 ` [PATCH 4/6] xfs: introduce background inode reclaim work Dave Chinner
2011-03-10 17:40 ` Christoph Hellwig
2011-03-18 4:00 ` Dave Chinner
2011-03-10 0:05 ` [PATCH 5/6] xfs: convert the xfsaild threads to a workqueue Dave Chinner
2011-03-10 17:48 ` Christoph Hellwig
2011-03-18 4:06 ` Dave Chinner [this message]
2011-03-19 13:45 ` Christoph Hellwig
2011-04-03 0:38 ` Dave Chinner
2011-04-03 10:59 ` Christoph Hellwig
2011-04-04 2:11 ` Dave Chinner
2011-03-10 0:05 ` [PATCH 6/6] xfs: push the AIL from memory reclaim and periodic sync Dave Chinner
2011-03-10 21:31 ` Christoph Hellwig
2011-03-18 4:07 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110318040648.GG30195@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox