From: Dave Chinner <david@fromorbit.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: aelder@sgi.com, xfs@oss.sgi.com
Subject: Re: xfs: outstanding patches for 2.6.39
Date: Wed, 23 Mar 2011 22:38:03 +1100 [thread overview]
Message-ID: <20110323113803.GB26611@dastard> (raw)
In-Reply-To: <m24o6u48xu.fsf@firstfloor.org>
On Wed, Mar 23, 2011 at 12:01:17AM -0700, Andi Kleen wrote:
> Dave Chinner <david@fromorbit.com> writes:
>
> > Of course, the major patch in this series is the conversion of the
> > buffer cache to using kmalloc and get_free_page() directly rather
> > than using the page cache. This has many benefits and I haven't
> > found any regressions due to making that change yet.
>
> One (somewhat obscure) regression will be that you won't be able to
> recover from uncorrected memory errors in the buffer cache anymore.
We can't do that right now, anyway.
> Previously memory_failure() could just drop it transparently when that
> happens and the page is currently not used.
If the page is not in use, we don't care about it after this patch
set is applied - the page is either active in a buffer or it has been
freed. If it is in use, then we'll shut the filesystem down if we
detect the memory corruption just like we currently do. Hence I
don't see any regression here.
As it is, there is no way for the filesytem to be notified about
such failures on active pages in buffers, so in reality we can't
reliably detect them so there is little point in trying to recover
from such errors.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-03-23 11:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 6:14 xfs: outstanding patches for 2.6.39 Dave Chinner
2011-03-23 6:14 ` [PATCH 1/6] xfs: preallocation transactions do not need to be synchronous Dave Chinner
2011-03-24 17:18 ` brian.foster
2011-03-24 22:53 ` [PATCH V2] " Dave Chinner
2011-03-25 21:00 ` [PATCH 1/6] " Alex Elder
2011-03-25 22:02 ` Dave Chinner
2011-03-23 6:14 ` [PATCH 2/6] vmap: flush vmap aliases when mapping fails Dave Chinner
2011-03-25 21:00 ` Alex Elder
2011-03-23 6:14 ` [PATCH 3/6] xfs: introduce inode cluster buffer trylocks for xfs_iflush Dave Chinner
2011-03-25 21:00 ` Alex Elder
2011-03-23 6:14 ` [PATCH 4/6] xfs: xfs_trans_read_buf() should return an error on failure Dave Chinner
2011-03-23 11:53 ` Christoph Hellwig
2011-03-25 21:01 ` Alex Elder
2011-03-23 6:14 ` [PATCH 5/6] xfs: register the inode cache shrinker before quotachecks Dave Chinner
2011-03-23 21:24 ` Arkadiusz Miskiewicz
2011-03-25 12:56 ` Michael Weissenbacher
2011-03-25 23:08 ` Dave Chinner
2011-03-25 21:01 ` Alex Elder
2011-03-23 6:14 ` [PATCH 6/6] xfs: stop using the page cache to back the buffer cache Dave Chinner
2011-03-25 21:02 ` Alex Elder
2011-03-25 22:04 ` Dave Chinner
2011-03-23 7:01 ` xfs: outstanding patches for 2.6.39 Andi Kleen
2011-03-23 11:38 ` Dave Chinner [this message]
2011-03-23 16:05 ` Andi Kleen
2011-03-23 22:48 ` Dave Chinner
2011-03-23 11:18 ` Christoph Hellwig
2011-03-23 11:38 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110323113803.GB26611@dastard \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=andi@firstfloor.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox