Re: [PATCH 1/6] xfs: preallocation transactions do not need to be synchronous

Dave Chinner
2011-03-25T21:59:14Z

On Fri, Mar 25, 2011 at 04:00:36PM -0500, Alex Elder wrote:
> On Wed, 2011-03-23 at 17:14 +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > Preallocation and hole punch transactions are currently synchronous
> > and this is causing performance problems in some cases. The
> > transactions don't need to be synchronous as we don't need to
> > guarantee the preallocation is persistent on disk until a
> > fdatasync, fsync, sync operation occurs. If the file is opened
> > O_SYNC or O_DATASYNC, only then should the transaction be issued
> > synchronously.
>
> There's a minor (but important) bug in this. Other than that
> this looks good.
>
> Reviewed-by: Alex Elder <aelder@sgi.com>

Already fixed and reposted.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com