From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH V2] xfstests 249: use -F option for xfs_io
Date: Thu, 24 Mar 2011 09:50:29 +1100 [thread overview]
Message-ID: <20110323225029.GF26611@dastard> (raw)
In-Reply-To: <4D8A19D4.3080807@redhat.com>
On Wed, Mar 23, 2011 at 11:03:32AM -0500, Eric Sandeen wrote:
> Test 249 was appearing to pass on ext4, but it wasn't really
> exercising the test due to lack of "-F" in the xfs_io arguments.
>
> Without -F the files were created (oddly enough); neither pwrite
> nor sendfile were executed, and the diff of the two (empty)
> files passed, resulting in a passed test without testing anything.
>
> So add the -F, capture the output, and test the result of each
> xfs_io invocation.
Ok.
> Also, when it fails, the diff output is huge. Make diff silent,
> but describe the diff failure and exit.
Excellent - I was going to suggest this myself given you were
touching this test.
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-03-23 22:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 15:53 [PATCH] xfstests 249: use -F option for xfs_io Eric Sandeen
2011-03-23 16:03 ` [PATCH V2] " Eric Sandeen
2011-03-23 22:50 ` Dave Chinner [this message]
2011-04-04 18:36 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110323225029.GF26611@dastard \
--to=david@fromorbit.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox