* Re: 2.6.38: Quota over NFS4 [not found] ` <20110323223017.GA5177@os.inf.tu-dresden.de> @ 2011-03-24 17:17 ` Christoph Hellwig 2011-03-24 17:51 ` J. Bruce Fields 0 siblings, 1 reply; 5+ messages in thread From: Christoph Hellwig @ 2011-03-24 17:17 UTC (permalink / raw) To: Adam Lackorzynski; +Cc: J. Bruce Fields, linux-nfs, xfs On Wed, Mar 23, 2011 at 11:30:17PM +0100, Adam Lackorzynski wrote: > I probably mistyped something and thus bisected again: maybe this is just a symptom. When was the nfs4 code converted to just use a single open struct file, and what are the lifetime rules for it? It would easily be that a long alive file might make XFS keep persistent preallocations longer or similar issues. Adam, can you create a loop filesystem with ext3 or something else on it and see if the problem is XFS-specific? _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.6.38: Quota over NFS4 2011-03-24 17:17 ` 2.6.38: Quota over NFS4 Christoph Hellwig @ 2011-03-24 17:51 ` J. Bruce Fields 2011-03-24 22:28 ` Adam Lackorzynski 0 siblings, 1 reply; 5+ messages in thread From: J. Bruce Fields @ 2011-03-24 17:51 UTC (permalink / raw) To: Christoph Hellwig; +Cc: linux-nfs, Adam Lackorzynski, xfs On Thu, Mar 24, 2011 at 01:17:05PM -0400, Christoph Hellwig wrote: > On Wed, Mar 23, 2011 at 11:30:17PM +0100, Adam Lackorzynski wrote: > > I probably mistyped something and thus bisected again: > > maybe this is just a symptom. When was the nfs4 code converted > to just use a single open struct file, and what are the lifetime > rules for it? It would easily be that a long alive file might > make XFS keep persistent preallocations longer or similar issues. Definitely, the commit he's bisect to there seems much more likely to be a culprit. I'll take a closer look.... > Adam, can you create a loop filesystem with ext3 or something else > on it and see if the problem is XFS-specific? Originally it sounded like he was able to reproduce this only on one specific filesystem so I wondered whether there was something particular to that filesystem. --b. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.6.38: Quota over NFS4 2011-03-24 17:51 ` J. Bruce Fields @ 2011-03-24 22:28 ` Adam Lackorzynski 2011-03-25 0:03 ` J. Bruce Fields 0 siblings, 1 reply; 5+ messages in thread From: Adam Lackorzynski @ 2011-03-24 22:28 UTC (permalink / raw) To: J. Bruce Fields; +Cc: Christoph Hellwig, linux-nfs, xfs On Thu Mar 24, 2011 at 13:51:06 -0400, J. Bruce Fields wrote: > On Thu, Mar 24, 2011 at 01:17:05PM -0400, Christoph Hellwig wrote: > > On Wed, Mar 23, 2011 at 11:30:17PM +0100, Adam Lackorzynski wrote: > > > I probably mistyped something and thus bisected again: > > > > maybe this is just a symptom. When was the nfs4 code converted > > to just use a single open struct file, and what are the lifetime > > rules for it? It would easily be that a long alive file might > > make XFS keep persistent preallocations longer or similar issues. > > Definitely, the commit he's bisect to there seems much more likely to be > a culprit. I'll take a closer look.... > > > Adam, can you create a loop filesystem with ext3 or something else > > on it and see if the problem is XFS-specific? > > Originally it sounded like he was able to reproduce this only on one > specific filesystem so I wondered whether there was something particular > to that filesystem. I just found out it happens also with a newly created xfs and also with ext3 and ext4. The reason that I did not see that initially is that the script I'm using needs to be on the same fs which wasn't the case when I initially tried it with a new fs. The sequence I'm using is: # mount x.x.x:/home /tmp/st # su - foo $ cd /tmp/st/foo/x $ ../test-script foo@host:/tmp/st/foo/x$ ../test-script Filesystem Inodes IUsed IFree IUse% Mounted on x.x.x:/home 39321600 15 39321585 1% /tmp/st Filesystem Inodes IUsed IFree IUse% Mounted on x.x.x:/home 39321600 16 39321584 1% /tmp/st Filesystem Inodes IUsed IFree IUse% Mounted on x.x.x:/home 39321600 16 39321584 1% /tmp/st test-script: #! /bin/sh df -i . cp /bin/ls x1 df -i . cat x1 > /dev/null rm x1 df -i . Adam -- Adam adam@os.inf.tu-dresden.de Lackorzynski http://os.inf.tu-dresden.de/~adam/ _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.6.38: Quota over NFS4 2011-03-24 22:28 ` Adam Lackorzynski @ 2011-03-25 0:03 ` J. Bruce Fields 2011-04-22 19:31 ` J. Bruce Fields 0 siblings, 1 reply; 5+ messages in thread From: J. Bruce Fields @ 2011-03-25 0:03 UTC (permalink / raw) To: Adam Lackorzynski; +Cc: Christoph Hellwig, linux-nfs, xfs On Thu, Mar 24, 2011 at 11:28:07PM +0100, Adam Lackorzynski wrote: > > On Thu Mar 24, 2011 at 13:51:06 -0400, J. Bruce Fields wrote: > > On Thu, Mar 24, 2011 at 01:17:05PM -0400, Christoph Hellwig wrote: > > > On Wed, Mar 23, 2011 at 11:30:17PM +0100, Adam Lackorzynski wrote: > > > > I probably mistyped something and thus bisected again: > > > > > > maybe this is just a symptom. When was the nfs4 code converted > > > to just use a single open struct file, and what are the lifetime > > > rules for it? It would easily be that a long alive file might > > > make XFS keep persistent preallocations longer or similar issues. > > > > Definitely, the commit he's bisect to there seems much more likely to be > > a culprit. I'll take a closer look.... > > > > > Adam, can you create a loop filesystem with ext3 or something else > > > on it and see if the problem is XFS-specific? > > > > Originally it sounded like he was able to reproduce this only on one > > specific filesystem so I wondered whether there was something particular > > to that filesystem. > > I just found out it happens also with a newly created xfs and also with > ext3 and ext4. The reason that I did not see that initially is that the > script I'm using needs to be on the same fs which wasn't the case when I > initially tried it with a new fs. The sequence I'm using is: Ah-hah, got it. So the leak's probably of a delegation on the file containing the script itself. OK, I should be able to fix that, thanks! --b. > > # mount x.x.x:/home /tmp/st > # su - foo > $ cd /tmp/st/foo/x > $ ../test-script > foo@host:/tmp/st/foo/x$ ../test-script > Filesystem Inodes IUsed IFree IUse% Mounted on > x.x.x:/home 39321600 15 39321585 1% /tmp/st > Filesystem Inodes IUsed IFree IUse% Mounted on > x.x.x:/home 39321600 16 39321584 1% /tmp/st > Filesystem Inodes IUsed IFree IUse% Mounted on > x.x.x:/home 39321600 16 39321584 1% /tmp/st > > > > test-script: > #! /bin/sh > > df -i . > cp /bin/ls x1 > df -i . > cat x1 > /dev/null > rm x1 > df -i . > > > > > > > Adam > -- > Adam adam@os.inf.tu-dresden.de > Lackorzynski http://os.inf.tu-dresden.de/~adam/ _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.6.38: Quota over NFS4 2011-03-25 0:03 ` J. Bruce Fields @ 2011-04-22 19:31 ` J. Bruce Fields 0 siblings, 0 replies; 5+ messages in thread From: J. Bruce Fields @ 2011-04-22 19:31 UTC (permalink / raw) To: Adam Lackorzynski; +Cc: Christoph Hellwig, linux-nfs, xfs On Thu, Mar 24, 2011 at 08:03:10PM -0400, J. Bruce Fields wrote: > On Thu, Mar 24, 2011 at 11:28:07PM +0100, Adam Lackorzynski wrote: > > > > On Thu Mar 24, 2011 at 13:51:06 -0400, J. Bruce Fields wrote: > > > On Thu, Mar 24, 2011 at 01:17:05PM -0400, Christoph Hellwig wrote: > > > > On Wed, Mar 23, 2011 at 11:30:17PM +0100, Adam Lackorzynski wrote: > > > > > I probably mistyped something and thus bisected again: > > > > > > > > maybe this is just a symptom. When was the nfs4 code converted > > > > to just use a single open struct file, and what are the lifetime > > > > rules for it? It would easily be that a long alive file might > > > > make XFS keep persistent preallocations longer or similar issues. > > > > > > Definitely, the commit he's bisect to there seems much more likely to be > > > a culprit. I'll take a closer look.... > > > > > > > Adam, can you create a loop filesystem with ext3 or something else > > > > on it and see if the problem is XFS-specific? > > > > > > Originally it sounded like he was able to reproduce this only on one > > > specific filesystem so I wondered whether there was something particular > > > to that filesystem. > > > > I just found out it happens also with a newly created xfs and also with > > ext3 and ext4. The reason that I did not see that initially is that the > > script I'm using needs to be on the same fs which wasn't the case when I > > initially tried it with a new fs. The sequence I'm using is: > > Ah-hah, got it. So the leak's probably of a delegation on the file > containing the script itself. OK, I should be able to fix that, thanks! This should be fixed in the latest upstream (so, in 39-rc5, when that comes out) and soon in stable. Let me know if not. --b. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-04-22 19:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20110320212633.GA26036@fieldses.org>
[not found] ` <20110320213111.GO11929@os.inf.tu-dresden.de>
[not found] ` <20110320214316.GB26036@fieldses.org>
[not found] ` <20110321184043.GC4992@os.inf.tu-dresden.de>
[not found] ` <20110321222301.GB472@fieldses.org>
[not found] ` <20110322221305.GA5857@os.inf.tu-dresden.de>
[not found] ` <20110323150328.GD23418@fieldses.org>
[not found] ` <20110323174052.GE5005@os.inf.tu-dresden.de>
[not found] ` <20110323190632.GA26306@fieldses.org>
[not found] ` <20110323223017.GA5177@os.inf.tu-dresden.de>
2011-03-24 17:17 ` 2.6.38: Quota over NFS4 Christoph Hellwig
2011-03-24 17:51 ` J. Bruce Fields
2011-03-24 22:28 ` Adam Lackorzynski
2011-03-25 0:03 ` J. Bruce Fields
2011-04-22 19:31 ` J. Bruce Fields
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox