From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with SMTP id p2TJLRtl244742 for ; Tue, 29 Mar 2011 14:21:27 -0500 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 20C7338A4C8 for ; Tue, 29 Mar 2011 12:24:37 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id h3gXWUWikVgpRyxV for ; Tue, 29 Mar 2011 12:24:37 -0700 (PDT) Date: Tue, 29 Mar 2011 15:24:34 -0400 From: "'Christoph Hellwig'" Subject: Re: XFS memory allocation deadlock in 2.6.38 Message-ID: <20110329192434.GA10536@infradead.org> References: <081DDE43F61F3D43929A181B477DCA95639B52FD@MSXAOA6.twosigma.com> <081DDE43F61F3D43929A181B477DCA95639B5327@MSXAOA6.twosigma.com> <20110324174311.GA31576@infradead.org> <081DDE43F61F3D43929A181B477DCA95639B5349@MSXAOA6.twosigma.com> <081DDE43F61F3D43929A181B477DCA95639B534E@MSXAOA6.twosigma.com> <081DDE43F61F3D43929A181B477DCA95639B5359@MSXAOA6.twosigma.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <081DDE43F61F3D43929A181B477DCA95639B5359@MSXAOA6.twosigma.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Sean Noonan Cc: Trammell Hudson , Christos Zoulas , Martin Bligh , "'linux-kernel@vger.kernel.org'" , Stephen Degler , 'Christoph Hellwig' , "'linux-mm@kvack.org'" , "'linux-xfs@oss.sgi.com'" , 'Michel Lespinasse' Can you check if the brute force patch below helps? If it does I still need to refine it a bit, but it could be that we are doing an allocation under an xfs lock that could recurse back into the filesystem. We have a per-process flag to disable that for normal kmalloc allocation, but we lost it for vmalloc in the commit you bisected the regression to. Index: xfs/fs/xfs/linux-2.6/kmem.h =================================================================== --- xfs.orig/fs/xfs/linux-2.6/kmem.h 2011-03-29 21:16:58.039224236 +0200 +++ xfs/fs/xfs/linux-2.6/kmem.h 2011-03-29 21:17:08.368223598 +0200 @@ -63,7 +63,7 @@ static inline void *kmem_zalloc_large(si { void *ptr; - ptr = vmalloc(size); + ptr = __vmalloc(size, GFP_NOFS | __GFP_HIGHMEM, PAGE_KERNEL); if (ptr) memset(ptr, 0, size); return ptr; _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs