From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p2TJeH7Z245792 for ; Tue, 29 Mar 2011 14:40:17 -0500 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 51B91115C73E for ; Tue, 29 Mar 2011 12:43:27 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id xRGoBlNkU3ffRgAy for ; Tue, 29 Mar 2011 12:43:27 -0700 (PDT) Date: Tue, 29 Mar 2011 15:43:24 -0400 From: "'Christoph Hellwig'" Subject: Re: XFS memory allocation deadlock in 2.6.38 Message-ID: <20110329194323.GA27840@infradead.org> References: <081DDE43F61F3D43929A181B477DCA95639B52FD@MSXAOA6.twosigma.com> <081DDE43F61F3D43929A181B477DCA95639B5327@MSXAOA6.twosigma.com> <20110324174311.GA31576@infradead.org> <081DDE43F61F3D43929A181B477DCA95639B5349@MSXAOA6.twosigma.com> <081DDE43F61F3D43929A181B477DCA95639B534E@MSXAOA6.twosigma.com> <081DDE43F61F3D43929A181B477DCA95639B5359@MSXAOA6.twosigma.com> <20110329192434.GA10536@infradead.org> <20110329193907.GK2310@cmpxchg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110329193907.GK2310@cmpxchg.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Johannes Weiner Cc: Trammell Hudson , Christos Zoulas , Sean Noonan , Martin Bligh , "'linux-kernel@vger.kernel.org'" , Stephen Degler , 'Christoph Hellwig' , "'linux-mm@kvack.org'" , "'linux-xfs@oss.sgi.com'" , 'Michel Lespinasse' On Tue, Mar 29, 2011 at 09:39:07PM +0200, Johannes Weiner wrote: > > - ptr = vmalloc(size); > > + ptr = __vmalloc(size, GFP_NOFS | __GFP_HIGHMEM, PAGE_KERNEL); > > if (ptr) > > memset(ptr, 0, size); > > return ptr; > > Note that vmalloc is currently broken in that it does a GFP_KERNEL > allocation if it has to allocate page table pages, even when invoked > with GFP_NOFS: > > http://marc.info/?l=linux-mm&m=128942194520631&w=4 Oh great. In that case we had a chance to hit the deadlock even before the offending commit, just a much smaller one. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs