From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 4/5] xfs: allow reusing busy extents where safe
Date: Thu, 31 Mar 2011 04:30:24 -0400 [thread overview]
Message-ID: <20110331083024.GA12865@infradead.org> (raw)
In-Reply-To: <1301425468.3026.249.camel@doink>
On Tue, Mar 29, 2011 at 02:04:28PM -0500, Alex Elder wrote:
> On Mon, 2011-03-28 at 17:06 -0400, Christoph Hellwig wrote:
> > Allow reusing any busy extent for metadata allocations, and reusing busy
> > userdata extents for userdata allocations. Most of the complexity is
> > propagating the userdata information from the XFS_BMAPI_METADATA flag
> > to xfs_bunmapi into the low-level extent freeing routines. After that
> > we can just track what type of busy extent we have and treat it accordingly.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> The use of an enum value returned from
> xfs_alloc_busy_update_extent() is a good improvement.
>
> I'll issue the caveat here that I did not look through
> it this time as carefully as the first time. My main
> concern was about the validity of reusing busy user data
> extents for user data, and as before I'll say I accept
> that it's OK, but I haven't worked through in my own
> mind that it is indeed safe. If I find the time to do
> it I'll look this one over again to for reassurance...
This version doesn't actually allow userdata reallocations anymore,
I just forgot to update the patch description.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-03-31 8:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 21:06 [PATCH 0/5] improved busy extent handling Christoph Hellwig
2011-03-28 21:06 ` [PATCH 1/5] xfs: optimize AGFL refills Christoph Hellwig
2011-03-29 19:04 ` Alex Elder
2011-03-28 21:06 ` [PATCH 2/5] xfs: do not immediately reuse busy extent ranges Christoph Hellwig
2011-03-29 19:04 ` Alex Elder
2011-03-28 21:06 ` [PATCH 3/5] xfs: exact busy extent tracking Christoph Hellwig
2011-03-29 19:04 ` Alex Elder
2011-03-28 21:06 ` [PATCH 4/5] xfs: allow reusing busy extents where safe Christoph Hellwig
2011-03-29 19:04 ` Alex Elder
2011-03-31 8:30 ` Christoph Hellwig [this message]
2011-03-28 21:06 ` [PATCH 5/5] xfs: update busy extent tracing Christoph Hellwig
2011-03-29 19:04 ` Alex Elder
2011-03-29 19:04 ` [PATCH 0/5] improved busy extent handling Alex Elder
2011-03-30 10:14 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110331083024.GA12865@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox