From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with SMTP id p2V8RGI8127968 for ; Thu, 31 Mar 2011 03:27:17 -0500 Date: Thu, 31 Mar 2011 04:30:24 -0400 From: Christoph Hellwig Subject: Re: [PATCH 4/5] xfs: allow reusing busy extents where safe Message-ID: <20110331083024.GA12865@infradead.org> References: <20110328210614.832613417@bombadil.infradead.org> <20110328210915.214513168@bombadil.infradead.org> <1301425468.3026.249.camel@doink> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1301425468.3026.249.camel@doink> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Alex Elder Cc: Christoph Hellwig , xfs@oss.sgi.com On Tue, Mar 29, 2011 at 02:04:28PM -0500, Alex Elder wrote: > On Mon, 2011-03-28 at 17:06 -0400, Christoph Hellwig wrote: > > Allow reusing any busy extent for metadata allocations, and reusing busy > > userdata extents for userdata allocations. Most of the complexity is > > propagating the userdata information from the XFS_BMAPI_METADATA flag > > to xfs_bunmapi into the low-level extent freeing routines. After that > > we can just track what type of busy extent we have and treat it accordingly. > > > > Signed-off-by: Christoph Hellwig > > The use of an enum value returned from > xfs_alloc_busy_update_extent() is a good improvement. > > I'll issue the caveat here that I did not look through > it this time as carefully as the first time. My main > concern was about the validity of reusing busy user data > extents for user data, and as before I'll say I accept > that it's OK, but I haven't worked through in my own > mind that it is indeed safe. If I find the time to do > it I'll look this one over again to for reassurance... This version doesn't actually allow userdata reallocations anymore, I just forgot to update the patch description. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs