From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix variable set but not used warnings
Date: Tue, 5 Apr 2011 15:10:06 -0400 [thread overview]
Message-ID: <20110405191006.GA7080@infradead.org> (raw)
In-Reply-To: <1301941280.2630.61.camel@doink>
On Mon, Apr 04, 2011 at 01:21:20PM -0500, Alex Elder wrote:
> > __int64_t sbflags;
> >
> > flags &= (XFS_ALL_QUOTA_ACCT | XFS_ALL_QUOTA_ENFD);
> > /*
> > * Switching on quota accounting must be done at mount time.
> > */
> > - accflags = flags & XFS_ALL_QUOTA_ACCT;
> > flags &= ~(XFS_ALL_QUOTA_ACCT);
>
> Unrelated, but isn't the effect of this line plus the one a few
> lines up the same as this?
>
> flags &= XFS_ALL_QUOTA_ENFD;
Yes, it is. I have a patch in my queue to clean this and a few others
bits around it up, but unlike the warnings fixes it's really 2.6.40
material.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-04-05 19:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 12:55 [PATCH] xfs: fix variable set but not used warnings Christoph Hellwig
2011-04-04 18:21 ` Alex Elder
2011-04-04 23:52 ` David Sterba
2011-04-05 6:05 ` Dave Chinner
2011-04-07 13:45 ` David Sterba
2011-04-05 19:10 ` Christoph Hellwig [this message]
2011-04-05 0:10 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110405191006.GA7080@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox