public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 9/9] xfs: convert log tail checking to a warning
Date: Wed, 6 Apr 2011 10:02:57 -0400	[thread overview]
Message-ID: <20110406140257.GB24618@infradead.org> (raw)
In-Reply-To: <1302070758-17312-10-git-send-email-david@fromorbit.com>

On Wed, Apr 06, 2011 at 04:19:18PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> On the Power platform, the log tail debug checks fire excessively
> causing the system to panic early in testing. The debug checks are
> known to be racy, though on x86_64 there is no evidence that they
> trigger at all.
> 
> We want to keep the checks active on debug systems to alert us to
> problems with log space accounting, but we need to reduce the impact
> of a racy check on testing on the Power platform.
> 
> As a result, convert the ASSERT conditions to warnings, and
> allow them to fire only once per filesystem mount. This will prevent
> false positives from interfering with testing, whilst still
> providing us with the indication that they may be a problem with log
> space accounting should that occur.
> 
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

Keeping a potentially racy debug check around still seems somewhat
fishy to me.  But you've done all the recent log work, so if it's
going to help you spot problems I'm fine with keeping it in this way,


Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2011-04-06 13:59 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-06  6:19 [PATCH 0/9] xfs: candidate fixes for 2.6.39 Dave Chinner
2011-04-06  6:19 ` [PATCH 1/9] xfs: fix extent format buffer allocation size Dave Chinner
2011-04-06 13:38   ` Christoph Hellwig
2011-04-07  0:05     ` Dave Chinner
2011-04-07 17:19       ` Christoph Hellwig
2011-04-06  6:19 ` [PATCH 2/9] xfs: introduce a xfssyncd workqueue Dave Chinner
2011-04-06  6:19 ` [PATCH 3/9] xfs: convert ENOSPC inode flushing to use new syncd workqueue Dave Chinner
2011-04-06  6:19 ` [PATCH 4/9] xfs: introduce background inode reclaim work Dave Chinner
2011-04-06 18:14   ` Christoph Hellwig
2011-04-07  0:06     ` Dave Chinner
2011-04-06  6:19 ` [PATCH 5/9] xfs: convert the xfsaild threads to a workqueue Dave Chinner
2011-04-06 18:12   ` Christoph Hellwig
2011-04-07  0:08     ` Dave Chinner
2011-04-06  6:19 ` [PATCH 6/9] xfs: clean up code layout in xfs_trans_ail.c Dave Chinner
2011-04-06 18:17   ` Christoph Hellwig
2011-04-07  0:08     ` Dave Chinner
2011-04-06  6:19 ` [PATCH 7/9] xfs: push the AIL from memory reclaim and periodic sync Dave Chinner
2011-04-06 18:33   ` Christoph Hellwig
2011-04-07  0:15     ` Dave Chinner
2011-04-06  6:19 ` [PATCH 8/9] xfs: catch bad block numbers freeing extents Dave Chinner
2011-04-06 13:59   ` Christoph Hellwig
2011-04-07  0:18     ` Dave Chinner
2011-04-06  6:19 ` [PATCH 9/9] xfs: convert log tail checking to a warning Dave Chinner
2011-04-06 14:02   ` Christoph Hellwig [this message]
2011-04-07  0:25     ` Dave Chinner
  -- strict thread matches above, loose matches on Subject: below --
2011-04-07  1:57 [PATCH 0/9] xfs; candidate fixes for 2.6.39 V2 Dave Chinner
2011-04-07  1:57 ` [PATCH 9/9] xfs: convert log tail checking to a warning Dave Chinner
2011-04-07 21:16   ` Alex Elder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110406140257.GB24618@infradead.org \
    --to=hch@infradead.org \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox