From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p3705gLw062801 for ; Wed, 6 Apr 2011 19:05:42 -0500 Received: from ipmail04.adl6.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 014F312B6D7C for ; Wed, 6 Apr 2011 17:08:58 -0700 (PDT) Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net [150.101.137.141]) by cuda.sgi.com with ESMTP id TMBUVcWNcRFwNlRq for ; Wed, 06 Apr 2011 17:08:58 -0700 (PDT) Date: Thu, 7 Apr 2011 10:08:32 +1000 From: Dave Chinner Subject: Re: [PATCH 6/9] xfs: clean up code layout in xfs_trans_ail.c Message-ID: <20110407000832.GP31057@dastard> References: <1302070758-17312-1-git-send-email-david@fromorbit.com> <1302070758-17312-7-git-send-email-david@fromorbit.com> <20110406181749.GC4356@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110406181749.GC4356@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Wed, Apr 06, 2011 at 02:17:49PM -0400, Christoph Hellwig wrote: > > +/* > > + * Return a pointer to the first item in the AIL. > > + * If the AIL is empty, then return NULL. > > + */ > > > +/* > > + * Return a pointer to the item which follows > > + * the given item in the AIL. If the given item > > + * is the last item in the list, then return NULL. > > + */ > > These comment seem to line break strangely early. > > > + ASSERT((&next_lip->li_ail == &ailp->xa_ail) || > > + (XFS_LSN_CMP(next_lip->li_lsn, lsn) <= 0)); > > no need for the inner braces here. > > > + list_splice_init(list, &next_lip->li_ail); > > + return; > > and no need for the return. > > > I know it's all nitpicking about pre-existing code, but when you touch > it anyway it might make sense to tidy it up. Makes sense, I'll clean them up. Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs