From: Christoph Hellwig <hch@lst.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: xfs-masters@oss.sgi.com, xfs@oss.sgi.com, dchinner@redhat.com
Subject: Re: [xfs-masters] [PATCH] xfs_destroy_workqueues() should not be tagged with __exit
Date: Mon, 11 Apr 2011 21:49:38 +0200 [thread overview]
Message-ID: <20110411194938.GA10683@lst.de> (raw)
In-Reply-To: <4da3512411659d3276@agluck-desktop.sc.intel.com>
On Mon, Apr 11, 2011 at 12:06:12PM -0700, Luck, Tony wrote:
> ia64 throws away .exit sections for the built-in CONFIG case, so routines
> that are used in other circumstances should not be tagged as __exit.
>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> ---
>
> Should be applied after (or merged into) Dave Chinner's patch
> xfs: convert the xfsaild threads to a workqueue
> which appeared as commit 0bf6a5bd4b55b466964ead6fa566d8f346a828ee in
> next-20110411
>
> diff --git a/fs/xfs/linux-2.6/xfs_super.c b/fs/xfs/linux-2.6/xfs_super.c
> index 67d5b2c..b38e58d 100644
> --- a/fs/xfs/linux-2.6/xfs_super.c
> +++ b/fs/xfs/linux-2.6/xfs_super.c
> @@ -1741,7 +1741,7 @@ out:
> return -ENOMEM;
> }
>
> -STATIC void __exit
> +STATIC void
> xfs_destroy_workqueues(void)
> {
> destroy_workqueue(xfs_ail_wq);
>
> _______________________________________________
> xfs-masters mailing list
> xfs-masters@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs-masters
---end quoted text---
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
parent reply other threads:[~2011-04-11 19:46 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <4da3512411659d3276@agluck-desktop.sc.intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110411194938.GA10683@lst.de \
--to=hch@lst.de \
--cc=dchinner@redhat.com \
--cc=tony.luck@intel.com \
--cc=xfs-masters@oss.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox