From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfs: kick inode writeback when low on memory
Date: Tue, 12 Apr 2011 07:14:46 +1000 [thread overview]
Message-ID: <20110411211446.GD21395@dastard> (raw)
In-Reply-To: <20110411183653.GD32346@infradead.org>
On Mon, Apr 11, 2011 at 02:36:53PM -0400, Christoph Hellwig wrote:
> How do you produce so many atime-dirty inodes? With relatime we
> should have cut down on the requirement for those a lot.
Copy a bunch of files, then md5sum them.
The copy modifies c/mtime, the md5sum modifies atime, sees mtime is
younger than atime, updates atime and dirties the inode. i.e.:
$ touch foo
$ stat foo
File: `foo'
Size: 0 Blocks: 0 IO Block: 4096 regular empty file
Device: fe02h/65026d Inode: 150756489 Links: 1
Access: (0644/-rw-r--r--) Uid: ( 1000/ dave) Gid: ( 1000/ dave)
Access: 2011-04-12 07:08:24.668542636 +1000
Modify: 2011-04-12 07:08:24.668542636 +1000
Change: 2011-04-12 07:08:24.668542636 +1000
$ cp README foo
cp: overwrite `foo'? y
$ stat foo
File: `foo'
Size: 17525 Blocks: 40 IO Block: 4096 regular file
Device: fe02h/65026d Inode: 150756489 Links: 1
Access: (0644/-rw-r--r--) Uid: ( 1000/ dave) Gid: ( 1000/ dave)
Access: 2011-04-12 07:08:24.668542636 +1000
Modify: 2011-04-12 07:08:44.676108103 +1000
Change: 2011-04-12 07:08:44.676108103 +1000
$ md5sum foo
9eb709847626f3663ea66121f10a27d7 foo
$ stat foo
File: `foo'
Size: 17525 Blocks: 40 IO Block: 4096 regular file
Device: fe02h/65026d Inode: 150756489 Links: 1
Access: (0644/-rw-r--r--) Uid: ( 1000/ dave) Gid: ( 1000/ dave)
Access: 2011-04-12 07:09:00.223770431 +1000
Modify: 2011-04-12 07:08:44.676108103 +1000
Change: 2011-04-12 07:08:44.676108103 +1000
$
> Do you have traces that show if we're kicking off additional data
> writeback this way too, or just pushing timestamp updates into
> the AIL?
For the test workload, it just pushes timestamp updates into the AIL
as that is the only thing that is dirtying the inodes when the OOM
occurs. In other situations, I have no evidence either way, but
I have not noticed any performance changes from a high level.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-04-11 21:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 6:19 [PATCH 0/2] xfs: write back inodes during reclaim Dave Chinner
2011-04-07 6:19 ` [PATCH 1/2] bdi: mark the bdi flusher busy when being forked Dave Chinner
2011-04-11 18:34 ` Christoph Hellwig
2011-04-13 19:29 ` Alex Elder
2011-04-07 6:19 ` [PATCH 2/2] xfs: kick inode writeback when low on memory Dave Chinner
2011-04-11 18:36 ` Christoph Hellwig
2011-04-11 21:14 ` Dave Chinner [this message]
2011-04-13 20:33 ` Alex Elder
2011-04-14 5:08 ` Dave Chinner
2011-04-15 8:09 ` Christoph Hellwig
2011-04-15 7:23 ` [PATCH 0/2] xfs: write back inodes during reclaim Yann Dupont
2011-04-15 7:54 ` Dave Chinner
2011-04-15 9:13 ` Yann Dupont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110411211446.GD21395@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox