From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix bmbt block allocation failures
Date: Tue, 12 Apr 2011 09:56:27 +1000 [thread overview]
Message-ID: <20110411235627.GF21395@dastard> (raw)
In-Reply-To: <20110411234158.GB29358@infradead.org>
On Mon, Apr 11, 2011 at 07:41:58PM -0400, Christoph Hellwig wrote:
> On Mon, Apr 11, 2011 at 12:34:11PM +1000, Dave Chinner wrote:
> > http://oss.sgi.com/archives/xfs/2010-09/msg00438.html). Firstly,
> > the missing args->total was causing the initial block to be
> > allocated from the freespace reserve. Secondly that the NEAR_BNO
> > allocation should probably be a START_BNO allocation to allow blocks
> > to be taken from a higher numbered AG.
>
> Looking over the use of ->total, isn't the ialloc btree code also
> incorrect by setting ->total to 0?
It probably is - I hadn't got that far yet. I wanted to get this
tested and reviewed so test 250 would no longer assert fail
everyone's debug build....
> The actual change looks good to me,
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-04-11 23:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 2:34 [PATCH] xfs: fix bmbt block allocation failures Dave Chinner
2011-04-11 23:41 ` Christoph Hellwig
2011-04-11 23:56 ` Dave Chinner [this message]
2011-04-12 0:55 ` Lachlan McIlroy
2011-04-12 6:53 ` Dave Chinner
2011-04-12 8:53 ` Dave Chinner
2011-04-15 7:29 ` Lachlan McIlroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110411235627.GF21395@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox