* [PATCH] xfstests: drop "Mount point match" from 028 and 047 golden output
@ 2011-03-01 22:53 Alex Elder
2011-03-02 0:05 ` Dave Chinner
0 siblings, 1 reply; 4+ messages in thread
From: Alex Elder @ 2011-03-01 22:53 UTC (permalink / raw)
To: xfs
Bill's latest update to xfsdump dropped a line of output that served
no real purpose. This change updates the golden output for the two
tests that included that line of output.
Signed-off-by: Alex Elder <aelder@sgi.com>
---
028.out | 1 -
047.out | 1 -
2 files changed, 2 deletions(-)
Index: b/028.out
===================================================================
--- a/028.out
+++ b/028.out
@@ -225,7 +225,6 @@ Processing file /var/xfsdump/inventory/U
/var/xfsdump/inventory/UUID.InvIndex
Checking access for
/var/xfsdump/inventory/UUID.StObj
- Mount point match
Session 0: HOSTNAME:SCRATCH_MNT
-------------------------------------------------
Pruning this matching entry:
Index: b/047.out
===================================================================
--- a/047.out
+++ b/047.out
@@ -225,7 +225,6 @@ Processing file /var/xfsdump/inventory/U
/var/xfsdump/inventory/UUID.InvIndex
Checking access for
/var/xfsdump/inventory/UUID.StObj
- Mount point match
Session 0: HOSTNAME:SCRATCH_MNT
-------------------------------------------------
An entry matching the mount point/time is :
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfstests: drop "Mount point match" from 028 and 047 golden output
2011-03-01 22:53 Alex Elder
@ 2011-03-02 0:05 ` Dave Chinner
0 siblings, 0 replies; 4+ messages in thread
From: Dave Chinner @ 2011-03-02 0:05 UTC (permalink / raw)
To: Alex Elder; +Cc: xfs
On Tue, Mar 01, 2011 at 04:53:17PM -0600, Alex Elder wrote:
> Bill's latest update to xfsdump dropped a line of output that served
> no real purpose. This change updates the golden output for the two
> tests that included that line of output.
>
> Signed-off-by: Alex Elder <aelder@sgi.com>
Hmmm - That means older versions of xfsdump will now fail the test
(e.g. running latest xfstests on RHEL/SLES installs). Can you
filter the output of xfsdump so that even older versions still pass
the test?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] xfstests: drop "Mount point match" from 028 and 047 golden output
@ 2011-04-21 18:53 Alex Elder
2011-04-22 6:47 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: Alex Elder @ 2011-04-21 18:53 UTC (permalink / raw)
To: xfs; +Cc: Alex Elder
Bill Kendall's latest update to xfsdump dropped a line of output
that served no real purpose. This change updates the golden output
for the two tests that included that line of output.
Updated to filter out that line from dump output also, so old
versions of the code will still produce the same output (suggested
by Dave Chinner).
Signed-off-by: Alex Elder <aelder@sgi.com>
---
028.out | 1 -
047.out | 1 -
common.dump | 1 +
3 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/028.out b/028.out
index 2b562a7..6804733 100644
--- a/028.out
+++ b/028.out
@@ -225,7 +225,6 @@ Processing file /var/xfsdump/inventory/UUIDstab
/var/xfsdump/inventory/UUID.InvIndex
Checking access for
/var/xfsdump/inventory/UUID.StObj
- Mount point match
Session 0: HOSTNAME:SCRATCH_MNT
-------------------------------------------------
Pruning this matching entry:
diff --git a/047.out b/047.out
index 7470329..31d9a34 100644
--- a/047.out
+++ b/047.out
@@ -225,7 +225,6 @@ Processing file /var/xfsdump/inventory/UUIDstab
/var/xfsdump/inventory/UUID.InvIndex
Checking access for
/var/xfsdump/inventory/UUID.StObj
- Mount point match
Session 0: HOSTNAME:SCRATCH_MNT
-------------------------------------------------
An entry matching the mount point/time is :
diff --git a/common.dump b/common.dump
index f330daf..c1eb675 100644
--- a/common.dump
+++ b/common.dump
@@ -814,6 +814,7 @@ _dump_filter_main()
-e '/\/dev\/tty/d' \
-e '/inventory session uuid/d' \
-e '/ - Running single-threaded/d' \
+ -e '/Mount point match/d' \
-e '/^.*I\/O metrics: .*$/d' \
-e 's/1048576/BLOCKSZ/' \
-e 's/2097152/BLOCKSZ/' \
--
1.7.4.4
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xfstests: drop "Mount point match" from 028 and 047 golden output
2011-04-21 18:53 [PATCH] xfstests: drop "Mount point match" from 028 and 047 golden output Alex Elder
@ 2011-04-22 6:47 ` Christoph Hellwig
0 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2011-04-22 6:47 UTC (permalink / raw)
To: Alex Elder; +Cc: xfs
On Thu, Apr 21, 2011 at 01:53:31PM -0500, Alex Elder wrote:
> Bill Kendall's latest update to xfsdump dropped a line of output
> that served no real purpose. This change updates the golden output
> for the two tests that included that line of output.
>
> Updated to filter out that line from dump output also, so old
> versions of the code will still produce the same output (suggested
> by Dave Chinner).
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-04-22 6:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-21 18:53 [PATCH] xfstests: drop "Mount point match" from 028 and 047 golden output Alex Elder
2011-04-22 6:47 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2011-03-01 22:53 Alex Elder
2011-03-02 0:05 ` Dave Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox