From: Dave Chinner <david@fromorbit.com>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: coalesce contiguous extents in extent map output
Date: Thu, 28 Apr 2011 12:08:46 +1000 [thread overview]
Message-ID: <20110428020846.GM12436@dastard> (raw)
In-Reply-To: <dd1c0747731332fed9637bc01d6c6de369a7fe6f.1303412098.git.aelder@sgi.com>
On Thu, Apr 21, 2011 at 01:55:03PM -0500, Alex Elder wrote:
> The specific set of extent sizes allocated to a file is not always
> deterministic. In particular, sometimes a range of unwritten blocks
> is covered by a single extent, while in other cases it might be
> represented by multiple consecutive unwritten extents. This can
> result in spurious errors being reported in tests that check file
> extent maps.
>
> Add a filter that finds adjacent extents in what gets produced for
> fiemap and bmap output and coalesces them as if all consective
> extents of the same time were really just one extent. (Note that
> as implemented here this applies to all extent types, not just
> unwritten extents.)
>
> Update the golden output for test 242 to reflect the change.
Looks sane. Does Josef's new test need the same golden output
treatment?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-04-28 2:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 18:55 [PATCH] xfstests: coalesce contiguous extents in extent map output Alex Elder
2011-04-28 2:08 ` Dave Chinner [this message]
2011-04-28 17:29 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110428020846.GM12436@dastard \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox