public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: make a few recently-added tests executable
Date: Thu, 28 Apr 2011 12:20:14 +1000	[thread overview]
Message-ID: <20110428022014.GP12436@dastard> (raw)
In-Reply-To: <2c89ad7f462d6a930703b9d68bc79ea666f6e7cc.1303422538.git.aelder@sgi.com>

On Thu, Apr 21, 2011 at 04:49:01PM -0500, Alex Elder wrote:
> By convention all of the tests in the xfstests suite have mode 0755.
> A few have recently committed without the execute bit set.
> 
> Signed-off-by: Alex Elder <aelder@sgi.com>
> ---
>  0 files changed, 0 insertions(+), 0 deletions(-)
>  mode change 100644 => 100755 246
>  mode change 100644 => 100755 247
>  mode change 100644 => 100755 248
>  mode change 100644 => 100755 250
>  mode change 100644 => 100755 251
>  mode change 100644 => 100755 252
> 
> diff --git a/246 b/246
> old mode 100644
> new mode 100755
> diff --git a/247 b/247
> old mode 100644
> new mode 100755
> diff --git a/248 b/248
> old mode 100644
> new mode 100755
> diff --git a/250 b/250
> old mode 100644
> new mode 100755
> diff --git a/251 b/251
> old mode 100644
> new mode 100755
> diff --git a/252 b/252
> old mode 100644
> new mode 100755

Looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2011-04-28  2:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-21 21:49 [PATCH] xfstests: make a few recently-added tests executable Alex Elder
2011-04-28  2:20 ` Dave Chinner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110428022014.GP12436@dastard \
    --to=david@fromorbit.com \
    --cc=aelder@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox