From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix compiler warning in xfs_trace.h
Date: Thu, 28 Apr 2011 12:20:36 +1000 [thread overview]
Message-ID: <20110428022036.GQ12436@dastard> (raw)
In-Reply-To: <20110424190258.GA32137@infradead.org>
On Sun, Apr 24, 2011 at 03:02:58PM -0400, Christoph Hellwig wrote:
> xfs_fsblock_t may be a 32-bit type on if XFS_BIG_BLKNOS is not set,
> make sure to cast a value of this type to an unsigned long long
> before using the ll printk qualifier.
>
> Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfs/fs/xfs/linux-2.6/xfs_trace.h
> ===================================================================
> --- xfs.orig/fs/xfs/linux-2.6/xfs_trace.h 2011-04-22 06:22:11.409709360 +0200
> +++ xfs/fs/xfs/linux-2.6/xfs_trace.h 2011-04-22 06:22:30.756271218 +0200
> @@ -1418,7 +1418,7 @@ DECLARE_EVENT_CLASS(xfs_alloc_class,
> __entry->wasfromfl,
> __entry->isfl,
> __entry->userdata,
> - __entry->firstblock)
> + (unsigned long long)__entry->firstblock)
> )
>
> #define DEFINE_ALLOC_EVENT(name) \
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-04-28 2:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-24 19:02 [PATCH] xfs: fix compiler warning in xfs_trace.h Christoph Hellwig
2011-04-28 2:20 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110428022036.GQ12436@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox