From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 0/4] use write_cache_pages
Date: Fri, 29 Apr 2011 10:40:58 +1000 [thread overview]
Message-ID: <20110429004058.GT12436@dastard> (raw)
In-Reply-To: <20110428125546.696493391@bombadil.infradead.org>
On Thu, Apr 28, 2011 at 08:55:46AM -0400, Christoph Hellwig wrote:
> Replace our own handcrafted I/O clustering with the generic write_cache_pages
> helper. While the old code would add any additional page in an existing
> mapping, the new code iterates over the pages, either adding them to
> a previous mapping if it fits or otherwise gets a new one.
>
> This has survived xfsqa for small and 4k blocksize on x86.
I've had a quick look at the patches, and I can't see anything
obvious that jumps out at me with a big red flag. It look slike a
very neat optimisation and simplification. I'll do some testing on
them before doing a more robust review, though....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-04-29 0:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 12:55 [PATCH 0/4] use write_cache_pages Christoph Hellwig
2011-04-28 12:55 ` [PATCH 1/4] xfs: PF_FSTRANS should never be set in ->writepage Christoph Hellwig
2011-05-25 2:18 ` Alex Elder
2011-05-25 7:46 ` Christoph Hellwig
2011-04-28 12:55 ` [PATCH 2/4] xfs: remove the unused ilock_nowait codepath in writepage Christoph Hellwig
2011-05-25 2:18 ` Alex Elder
2011-04-28 12:55 ` [PATCH 3/4] xfs: use write_cache_pages for writeback clustering Christoph Hellwig
2011-04-28 12:55 ` [PATCH 4/4] xfs: cleanup xfs_add_to_ioend Christoph Hellwig
2011-04-29 0:40 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110429004058.GT12436@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox