public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/4] xfs: do not immediately reuse busy extent ranges
Date: Fri, 29 Apr 2011 10:58:24 +1000	[thread overview]
Message-ID: <20110429005824.GV12436@dastard> (raw)
In-Reply-To: <20110424190656.849588824@bombadil.infradead.org>

On Sun, Apr 24, 2011 at 03:06:15PM -0400, Christoph Hellwig wrote:
> Every time we reallocate a busy extent, we cause a synchronous log force
> to occur to ensure the freeing transaction is on disk before we continue
> and use the newly allocated extent.  This is extremely sub-optimal as we
> have to mark every transaction with blocks that get reused as synchronous.
> 
> Instead of searching the busy extent list after deciding on the extent to
> allocate, check each candidate extent during the allocation decisions as
> to whether they are in the busy list.  If they are in the busy list, we
> trim the busy range out of the extent we have found and determine if that
> trimmed range is still OK for allocation. In many cases, this check can
> be incorporated into the allocation extent alignment code which already
> does trimming of the found extent before determining if it is a valid
> candidate for allocation.
> 
> Based on earlier patches from Dave Chinner.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Alex Elder <aelder@sgi.com>

Reviewed-by: Dave Chinner <dchinner@redhat.com>

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2011-04-29  0:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-24 19:06 [PATCH 0/4] improved busy extent handling V5 Christoph Hellwig
2011-04-24 19:06 ` [PATCH 1/4] xfs: optimize AGFL refills Christoph Hellwig
2011-04-29  0:41   ` Dave Chinner
2011-04-24 19:06 ` [PATCH 2/4] xfs: do not immediately reuse busy extent ranges Christoph Hellwig
2011-04-29  0:58   ` Dave Chinner [this message]
2011-04-24 19:06 ` [PATCH 3/4] xfs: exact busy extent tracking Christoph Hellwig
2011-04-29  1:10   ` Dave Chinner
2011-04-24 19:06 ` [PATCH 4/4] xfs: reduce the number of pagb_lock roundtrips in xfs_alloc_clear_busy Christoph Hellwig
2011-04-27 16:56   ` Alex Elder
2011-04-27 19:45     ` Christoph Hellwig
2011-04-29  1:13     ` Dave Chinner
  -- strict thread matches above, loose matches on Subject: below --
2011-04-18  6:59 [PATCH 0/4] improved busy extent handling V4 Christoph Hellwig
2011-04-18  6:59 ` [PATCH 2/4] xfs: do not immediately reuse busy extent ranges Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110429005824.GV12436@dastard \
    --to=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox