From: Dave Chinner <david@fromorbit.com>
To: Alex Elder <aelder@sgi.com>
Cc: Joe Perches <joe@perches.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: kill off xfs_printk()
Date: Wed, 4 May 2011 10:44:54 +1000 [thread overview]
Message-ID: <20110504004453.GC9114@dastard> (raw)
In-Reply-To: <a7077b2b2f6f46ac48d03cff4ccede2feba18f07.1304453673.git.aelder@sgi.com>
On Tue, May 03, 2011 at 03:14:44PM -0500, Alex Elder wrote:
> From: Joe Perches <joe@perches.com>
>
> xfs_alert_tag() can be defined using xfs_alert(), and thereby avoid
> using xfs_printk() altogether. This is the only remaining use of
> xfs_printk(), so changing it this way means xfs_printk() can simply
> be eliminated.can simply be eliminated.can simply be eliminated.can
> simply be eliminated.can simply be eliminated.can simply be
> eliminated.can simply be eliminated.can simply be eliminated.can
> simply be eliminated.
>
> Also add format checking to the non-debug inline function xfs_debug.
> Miscellaneous function prototype argument alignment.
>
> (Updated to delete the definition of xfs_printk(), which is
> no longer used or needed.)
>
> Signed-off-by: Alex Elder <aelder@sgi.com>
If you are going to credit Joe as the original source of the patch
in the commit (i.e. via the "From:" tag), you probably should copy
in his original Signed-off-by tag as well....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-05-04 0:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 20:14 [PATCH] xfs: kill off xfs_printk() Alex Elder
2011-05-03 20:21 ` Alex Elder
2011-05-03 20:27 ` Joe Perches
2011-05-04 0:44 ` Dave Chinner [this message]
2011-05-04 14:29 ` Alex Elder
2011-05-04 14:54 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110504004453.GC9114@dastard \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=joe@perches.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox