From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p440fVTn042976 for ; Tue, 3 May 2011 19:41:32 -0500 Received: from ipmail04.adl6.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 534141E1B038 for ; Tue, 3 May 2011 17:45:07 -0700 (PDT) Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net [150.101.137.141]) by cuda.sgi.com with ESMTP id UP0UmsMiQHJ677Wg for ; Tue, 03 May 2011 17:45:07 -0700 (PDT) Date: Wed, 4 May 2011 10:44:54 +1000 From: Dave Chinner Subject: Re: [PATCH] xfs: kill off xfs_printk() Message-ID: <20110504004453.GC9114@dastard> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Alex Elder Cc: Joe Perches , xfs@oss.sgi.com On Tue, May 03, 2011 at 03:14:44PM -0500, Alex Elder wrote: > From: Joe Perches > > xfs_alert_tag() can be defined using xfs_alert(), and thereby avoid > using xfs_printk() altogether. This is the only remaining use of > xfs_printk(), so changing it this way means xfs_printk() can simply > be eliminated.can simply be eliminated.can simply be eliminated.can > simply be eliminated.can simply be eliminated.can simply be > eliminated.can simply be eliminated.can simply be eliminated.can > simply be eliminated. > > Also add format checking to the non-debug inline function xfs_debug. > Miscellaneous function prototype argument alignment. > > (Updated to delete the definition of xfs_printk(), which is > no longer used or needed.) > > Signed-off-by: Alex Elder If you are going to credit Joe as the original source of the patch in the commit (i.e. via the "From:" tag), you probably should copy in his original Signed-off-by tag as well.... Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs