From: Christoph Hellwig <hch@infradead.org>
To: Bill Kendall <wkendall@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfsprogs: fix open_by_handle memory leak
Date: Mon, 9 May 2011 10:06:57 -0400 [thread overview]
Message-ID: <20110509140656.GA12262@infradead.org> (raw)
In-Reply-To: <1304700177-8505-1-git-send-email-wkendall@sgi.com>
On Fri, May 06, 2011 at 11:42:57AM -0500, Bill Kendall wrote:
> open_by_handle() calls handle_to_fshandle() which
> allocates an fshandle on the heap, which is never
> freed by open_by_handle(). There is no need to
> call handle_to_fshandle() though, just pass the
> fhandle (rather than fshandle) to handle_to_fsfd(),
> like the other *_by_handle() functions do.
>
> Signed-off-by: Bill Kendall <wkendall@sgi.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-05-09 14:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 16:42 [PATCH] xfsprogs: fix open_by_handle memory leak Bill Kendall
2011-05-09 14:06 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110509140656.GA12262@infradead.org \
--to=hch@infradead.org \
--cc=wkendall@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox