From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Marc Lehmann <schmorp@schmorp.de>, xfs@oss.sgi.com
Subject: Re: drastic changes to allocsize semantics in or around 2.6.38?
Date: Mon, 23 May 2011 05:01:44 -0400 [thread overview]
Message-ID: <20110523090144.GB15985@infradead.org> (raw)
In-Reply-To: <20110523012034.GA32466@dastard>
On Mon, May 23, 2011 at 11:20:34AM +1000, Dave Chinner wrote:
>
> The state used to track dirty inode release calls is not reset when
> an inode is reallocated and reused from the reclaimable state. This
> leads to specualtive preallocation not being truncated away in the
> expected manner for local files until the inode is subsequently
> truncated, freed or cycles out of the cache.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> fs/xfs/xfs_iget.c | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/fs/xfs/xfs_iget.c b/fs/xfs/xfs_iget.c
> index cb9b6d1..e75e757 100644
> --- a/fs/xfs/xfs_iget.c
> +++ b/fs/xfs/xfs_iget.c
> @@ -241,6 +241,13 @@ xfs_iget_cache_hit(
> */
> ip->i_flags |= XFS_IRECLAIM;
>
> + /*
> + * clear the dirty release state as we are now effectively a
> + * new inode and so we need to treat speculative preallocation
> + * accordingly.
> + */
> + ip->i_flags &= ~XFS_IDIRTY_RELEASE;
Btw, don't we need to clear even more flags here? To me it seems we
need to clear XFS_ISTALE, XFS_IFILESTREAM and XFS_ITRUNCATED as well.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-05-23 9:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 0:55 drastic changes to allocsize semantics in or around 2.6.38? Marc Lehmann
2011-05-20 2:56 ` Dave Chinner
2011-05-20 15:49 ` Marc Lehmann
2011-05-21 0:45 ` Dave Chinner
2011-05-21 1:36 ` Marc Lehmann
2011-05-21 3:15 ` Dave Chinner
2011-05-21 4:16 ` Marc Lehmann
2011-05-22 2:00 ` Dave Chinner
2011-05-22 7:59 ` Matthias Schniedermeyer
2011-05-23 1:20 ` Dave Chinner
2011-05-23 9:01 ` Christoph Hellwig [this message]
2011-05-24 0:20 ` Dave Chinner
2011-05-23 13:35 ` Marc Lehmann
2011-05-24 1:30 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110523090144.GB15985@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=schmorp@schmorp.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox