From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p4VK9vWw075604 for ; Tue, 31 May 2011 15:09:57 -0500 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 9A6BAD6459C for ; Tue, 31 May 2011 13:09:55 -0700 (PDT) Received: from bombadil.infradead.org (173-166-109-252-newengland.hfc.comcastbusiness.net [173.166.109.252]) by cuda.sgi.com with ESMTP id XsZSDTKMGUBUwMVa for ; Tue, 31 May 2011 13:09:55 -0700 (PDT) Date: Tue, 31 May 2011 16:09:50 -0400 From: Christoph Hellwig Subject: Re: [PATCH 1/2] xfs: clear inode per-lifetime state when recycling it Message-ID: <20110531200950.GA31713@infradead.org> References: <1306815659-23346-1-git-send-email-david@fromorbit.com> <1306815659-23346-2-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1306815659-23346-2-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com Looks good. Reviewed-by: Christoph Hellwig > + * XXX(dgc): should the XFS_ISTALE flag only be cleared here? I think so. Right now any iget on a stale inode will clear it, which is very wrong. Care to send a separate patch for that? _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs