From: Christoph Hellwig <hch@infradead.org>
To: Allison Henderson <achender@linux.vnet.ibm.com>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
xfs-oss <xfs@oss.sgi.com>
Subject: Re: Port xfstests 145, 161, 175, 176, 185?
Date: Thu, 9 Jun 2011 07:08:26 -0400 [thread overview]
Message-ID: <20110609110826.GA14899@infradead.org> (raw)
In-Reply-To: <4DEFC41A.9070701@linux.vnet.ibm.com>
On Wed, Jun 08, 2011 at 11:48:58AM -0700, Allison Henderson wrote:
> During one of my reviews for the punch hole tests patch set it was
> mentioned that it would be helpful to take the xfstests 145, 161,
> 175, 176, 185 and modify them such that they can run with out
> requiring the dmapi. These tests contain some more interesting
> punch hole tests, but they dont normally run unless there is support
> for dmapi.
>
> I did take a peek at them and I was thinking that if we decide to do
> this, we would probably need to do something like introduce a new
> set of source code that is similar to what is seen under the dmapi
> folder, but modified to use a generic interface instead of the dmapi
> libraries. We could try to merge them into a single code path, but
> I think that may introduce more complexities than would be
> desirable.
Most of it should be doable using xfs_io. If it's nessecary to write
new source files because of e.g. concurrency tests that we can't easily
do from xfs_io please add new source files to the src/ directory.
Also, please don't rewrite the actual existing dmapi test cases, but
add new ones testing these patterns using the fallocate interface, as
the coverage for the dmapi interface still is useful.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-06-09 11:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 18:48 Port xfstests 145, 161, 175, 176, 185? Allison Henderson
2011-06-09 11:08 ` Christoph Hellwig [this message]
2011-06-09 19:17 ` Allison Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110609110826.GA14899@infradead.org \
--to=hch@infradead.org \
--cc=achender@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox