From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p5ALfnTb011985 for ; Fri, 10 Jun 2011 16:41:49 -0500 Received: from ipmail06.adl6.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id EF2DD4B7AD5 for ; Fri, 10 Jun 2011 14:41:47 -0700 (PDT) Received: from ipmail06.adl6.internode.on.net (ipmail06.adl6.internode.on.net [150.101.137.145]) by cuda.sgi.com with ESMTP id OsBdADizAilkzWA6 for ; Fri, 10 Jun 2011 14:41:47 -0700 (PDT) Date: Sat, 11 Jun 2011 07:41:43 +1000 From: Dave Chinner Subject: Re: Failure of xfstests test case 202 Message-ID: <20110610214143.GZ32466@dastard> References: <1307738387.7661.450.camel@chandra-lucid.beaverton.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1307738387.7661.450.camel@chandra-lucid.beaverton.ibm.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Chandra Seetharaman Cc: XFS Mailing List On Fri, Jun 10, 2011 at 01:39:47PM -0700, Chandra Seetharaman wrote: > Hi all, > > Test case 202 tries to create a single AG filesystem and runs xfs_repair > on it expecting it to fail. > > But, when I run the test with a filesystem that is bigger than 1TB it > fails (not pleasantly) since the max AG size is 1TB. > > I am thinking of the following solution, please let me know if there is > any other elegant fix. > > chandra > ------------------------ > diff --git a/202 b/202 > index cbdcb57..b871d8b 100755 > --- a/202 > +++ b/202 > @@ -42,10 +42,12 @@ _supported_os Linux > _require_scratch > > echo "== Creating single-AG filesystem ==" > -_scratch_mkfs_xfs -d agcount=1 >/dev/null 2>&1 > +_scratch_mkfs_xfs -d agcount=1 >/dev/null 2>&1 \ > + || _scratch_mkfs_xfs -d agcount=1 -d size=268435455b >/dev/null 2>&1 > + || _fail "!!! failed to make filesystem" Why the second mkfs attempt with a fixed block size? That will still fail for block size > 4k. All you need to do is detect the first attempt failed. > > echo "== Trying to repair it (should fail) ==" > -_scratch_xfs_repair > +_scratch_xfs_repair && _fail "!!! xfs_repair of single AG filesystem > succeeded" This is not necessary - the golden image compare at the end of the test will detect this succeeding when it shoul dbe failing. Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs