From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Trammell Hudson <Trammell.Hudson@twosigma.com>,
Sean Noonan <Sean.Noonan@twosigma.com>,
Martin Bligh <Martin.Bligh@twosigma.com>,
Ian Baum <Ian.Baum@twosigma.com>,
Stephen Degler <Stephen.Degler@twosigma.com>,
Christoph Hellwig <hch@infradead.org>,
"'linux-xfs@oss.sgi.com'" <linux-xfs@oss.sgi.com>
Subject: Re: sparse file handling bug in XFS
Date: Mon, 20 Jun 2011 08:27:23 +1000 [thread overview]
Message-ID: <20110619222723.GJ561@dastard> (raw)
In-Reply-To: <4DFA70B7.5080206@sandeen.net>
On Thu, Jun 16, 2011 at 04:08:07PM -0500, Eric Sandeen wrote:
> On 6/16/11 12:57 PM, Christoph Hellwig wrote:
> > On Thu, Jun 16, 2011 at 12:33:49PM -0500, Eric Sandeen wrote:
> >> Actually this looks like it's a result of
> >>
> >> 6e857567dbbfe14dd6cc3f7414671b047b1ff5c7 xfs: don't truncate prealloc from frequently accessed inodes
> >>
> >> I thought Dave's patch from the "Re: drastic changes to allocsize semantics in or around 2.6.38?"
> >> thread would fix it, but it doesn't seem to. Here it is anyway ;)
> >
> > It should fix the thing about the preallocation staying when removing
> > and recreating the file. Keeping pre-allocate blocks around otherwise
> > is a considered a feature.
>
> It strikes me as odd that truncating & rewriting would lead to
> different preallocation though .. I'll let Dave chime in.
Yeah, it's an oversight - we should reset the XFS_IDIRTY_RELEASE
flag when we set the XFS_ITRUNCATED flag. We remove the
preallocation beyond EOF when we truncate, so we should also trash
the state that tries to preserve it at the same time....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-06-19 22:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 14:49 sparse file handling bug in XFS Sean Noonan
2011-06-16 16:08 ` Eric Sandeen
2011-06-16 17:33 ` Eric Sandeen
2011-06-16 17:57 ` Christoph Hellwig
2011-06-16 21:08 ` Eric Sandeen
2011-06-19 22:27 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110619222723.GJ561@dastard \
--to=david@fromorbit.com \
--cc=Ian.Baum@twosigma.com \
--cc=Martin.Bligh@twosigma.com \
--cc=Sean.Noonan@twosigma.com \
--cc=Stephen.Degler@twosigma.com \
--cc=Trammell.Hudson@twosigma.com \
--cc=hch@infradead.org \
--cc=linux-xfs@oss.sgi.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox