From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p5JMRRNs077121 for ; Sun, 19 Jun 2011 17:27:27 -0500 Received: from ipmail07.adl2.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id A38DF1349CA3 for ; Sun, 19 Jun 2011 15:27:25 -0700 (PDT) Received: from ipmail07.adl2.internode.on.net (ipmail07.adl2.internode.on.net [150.101.137.131]) by cuda.sgi.com with ESMTP id jc4bv8LFv09HG2fG for ; Sun, 19 Jun 2011 15:27:25 -0700 (PDT) Date: Mon, 20 Jun 2011 08:27:23 +1000 From: Dave Chinner Subject: Re: sparse file handling bug in XFS Message-ID: <20110619222723.GJ561@dastard> References: <081DDE43F61F3D43929A181B477DCA95639B561F@MSXAOA6.twosigma.com> <4DFA2A76.6000104@sandeen.net> <4DFA3E7D.4030408@sandeen.net> <20110616175743.GA20570@infradead.org> <4DFA70B7.5080206@sandeen.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4DFA70B7.5080206@sandeen.net> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: Trammell Hudson , Sean Noonan , Martin Bligh , Ian Baum , Stephen Degler , Christoph Hellwig , "'linux-xfs@oss.sgi.com'" On Thu, Jun 16, 2011 at 04:08:07PM -0500, Eric Sandeen wrote: > On 6/16/11 12:57 PM, Christoph Hellwig wrote: > > On Thu, Jun 16, 2011 at 12:33:49PM -0500, Eric Sandeen wrote: > >> Actually this looks like it's a result of > >> > >> 6e857567dbbfe14dd6cc3f7414671b047b1ff5c7 xfs: don't truncate prealloc from frequently accessed inodes > >> > >> I thought Dave's patch from the "Re: drastic changes to allocsize semantics in or around 2.6.38?" > >> thread would fix it, but it doesn't seem to. Here it is anyway ;) > > > > It should fix the thing about the preallocation staying when removing > > and recreating the file. Keeping pre-allocate blocks around otherwise > > is a considered a feature. > > It strikes me as odd that truncating & rewriting would lead to > different preallocation though .. I'll let Dave chime in. Yeah, it's an oversight - we should reset the XFS_IDIRTY_RELEASE flag when we set the XFS_ITRUNCATED flag. We remove the preallocation beyond EOF when we truncate, so we should also trash the state that tries to preserve it at the same time.... Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs