* XFS Kconfig variable XFS_TRACE not defined anywhere
@ 2011-06-19 11:24 Robert P. J. Day
2011-06-20 7:44 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Robert P. J. Day @ 2011-06-19 11:24 UTC (permalink / raw)
To: xfs
just FYI:
===== XFS_TRACE =====
./fs/xfs/Makefile:xfs-$(CONFIG_XFS_TRACE) += xfs_btree_trace.o
as far as i can tell, there is no definition of the Kconfig variable
XFS_TRACE, so that Makefile entry is redundant.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: XFS Kconfig variable XFS_TRACE not defined anywhere
2011-06-19 11:24 XFS Kconfig variable XFS_TRACE not defined anywhere Robert P. J. Day
@ 2011-06-20 7:44 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2011-06-20 7:44 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: xfs
On Sun, Jun 19, 2011 at 07:24:46AM -0400, Robert P. J. Day wrote:
>
> just FYI:
>
> ===== XFS_TRACE =====
> ./fs/xfs/Makefile:xfs-$(CONFIG_XFS_TRACE) += xfs_btree_trace.o
>
> as far as i can tell, there is no definition of the Kconfig variable
> XFS_TRACE, so that Makefile entry is redundant.
It's part of the old kdb-only tracing implementation and now dead. We
left it in as a reminder to still convert the btree tracing code to
trace events once the technology for it becomes awailable. At this
point I suspect we could simply remove it as we still have the code
available in git history. And xfs_btree_trace.c itself doesn't contain
any interesting code anyway as the interesting bits are in the macros
which we are going to keep anyway.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-20 7:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-19 11:24 XFS Kconfig variable XFS_TRACE not defined anywhere Robert P. J. Day
2011-06-20 7:44 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox