From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: bpm@sgi.com, xfs@oss.sgi.com, aelder@sgi.com
Subject: Re: [PATCH] xfs: only SetPageUptodate if all buffers are uptodate
Date: Thu, 23 Jun 2011 20:35:59 +1000 [thread overview]
Message-ID: <20110623103559.GZ32466@dastard> (raw)
In-Reply-To: <20110623060900.GX32466@dastard>
On Thu, Jun 23, 2011 at 04:09:00PM +1000, Dave Chinner wrote:
> On Thu, Jun 23, 2011 at 03:08:19PM +1000, Dave Chinner wrote:
> > On Wed, Apr 20, 2011 at 11:36:14AM -0400, Christoph Hellwig wrote:
> > > On Wed, Apr 20, 2011 at 09:57:22AM -0500, bpm@sgi.com wrote:
> > > > Wish I did. The test case that discovered this only applies to CXFS. I
> > > > would have liked to post a test case for XFS but decided that this has
> > > > been on my TODO list for too long already. Looks to me like it has to
> > > > be related to the inode size, so you quit probing buffers after the
> > > > first. Maybe some discussion will ring some bells for somebody.
> > >
> > > It would be really good to have one, but the actual patch looks good
> > > enough that I'd consider putting it in. I can assumes you ran
> > > xfstests with various small blocksize options for both the test
> > > and scratch device and it didn't show any regressions?
> >
> > I've been running this patch for quite some time, but having just
> > upgraded to the latest xfstests, this patch is causing fsx failures
> > in tests 075 091 112 127 and 231 on 3.0-rc4 on x86_64 with default
> > mkfs and mount parameters. fsx passes again with this patch removed
> > from my test stack....
>
> Seems I spoke too soon - the fsx failures seems to be intermittent,
> and it was just chance that my bisect landed on this patch....
I've reproduced the fsx failure with an unmodified, top-of-tree
Linus 3.0-rc kernel, so it's time to start the mainline bisect dance
again.....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-06-23 10:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 11:40 [PATCH] xfs: only SetPageUptodate if all buffers are uptodate Ben Myers
2011-04-20 10:35 ` Christoph Hellwig
2011-04-20 14:57 ` bpm
2011-04-20 15:36 ` Christoph Hellwig
2011-06-23 5:08 ` Dave Chinner
2011-06-23 6:09 ` Dave Chinner
2011-06-23 10:35 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110623103559.GZ32466@dastard \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=bpm@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox